Fix order of items not always saved

[Fedik]

Pull Request for Issue #38910 .

Summary of Changes

Use input.value = x, instead of input.setAttribute('value', x)

Testing Instructions

Apply patch, run npm install.

And follow #38910 , or:

Open sample data menus list for Top menu.
Drag "Fruit Shop" to:
3-d position, check frontend - position should change,
then drag to 5-th position, check fronted - position stays 3-rd
Important: do not reload the menu list page.

Actual result BEFORE applying this Pull Request

Order randomly saved wrongly

Expected result AFTER applying this Pull Request

Order always saved

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[wwwiiimmm]

I have tested this item ✅ successfully on b460ee4

I used the Custom URL in Joomla Updater to install this PR.
After that I dragged menu items and featured articles to different possitions.

From what I can see this fixes the order issue.

Thank you.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38935.}

[richard67]

I have tested this item ✅ successfully on b460ee4

I could reliably reproduce the issue. It always failed for me when I dragged an item to the very last position of the menu items list. I can confirm the patch solves this.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38935.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38935.}

[HLeithner]

Thanks and just a reference https://stackoverflow.com/questions/29929797/setattribute-doesnt-work-the-way-i-expect-it-to