Merged
Conversation
Make IDE happy with the code like `$app->input->json->getRaw()`
wilsonge
approved these changes
Oct 18, 2022
HLeithner
approved these changes
Oct 23, 2022
bembelimen
approved these changes
Oct 23, 2022
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Make IDE happy with the code like
$app->input->json->getRaw()Testing Instructions
Apply patch, see IDE tips. The json input is mostly used in API controllers.
A PR is also required for Input package: joomla-framework/input#40
Actual result BEFORE applying this Pull Request
$app->input->jsonand$app->input->json->getRaw()are incorrectly parsed by IDE.Expected result AFTER applying this Pull Request
$app->input->jsonand$app->input->json->getRaw()are correctly parsed by IDE.+
mistyped Json input usage in application config model.