Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Oct 4, 2022

Pull Request for Issue #37054 .

Summary of Changes

Update our jdragndrop plugin to work only with "Files".

Testing Instructions

Run npm install, and follow #37054
Would be nice to test in all Browsers.

Actual result BEFORE applying this Pull Request

Text drag is broken
Image upload works

Expected result AFTER applying this Pull Request

Text drag works
Image upload works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

Added release blocker label as inherited from the issue.

@HLeithner
Copy link
Member

I have tested this item ✅ successfully on 9f521c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9f521c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.

@alikon
Copy link
Contributor

alikon commented Oct 6, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed Release Blocker labels Oct 6, 2022
@roland-d
Copy link
Contributor

roland-d commented Oct 7, 2022

@Fedik After checking out this branch, running npm ci and testing the editor, the drag and drop of text works but drag and drop of images no longer works. I do not get the dotted line around the block nor does anything happen when I drop the image on the editor.

This is running Firefox 105.0.2 on Linux.

@Fedik
Copy link
Member Author

Fedik commented Oct 7, 2022

Thanks for checking that. I have fixed Firefox. Please test again

@N6REJ
Copy link
Contributor

N6REJ commented Oct 8, 2022

I have tested this item 🔴 unsuccessfully on c683ae2

Works in firefox but not in chrome
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.

@Fedik
Copy link
Member Author

Fedik commented Oct 8, 2022

I set it back to Pending

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 8, 2022
@Fedik
Copy link
Member Author

Fedik commented Oct 8, 2022

@N6REJ are you sure it not a browser cache?
For me works in Chrome and Firfox

@roland-d
Copy link
Contributor

roland-d commented Oct 9, 2022

I have tested this item ✅ successfully on c683ae2

Before applying the patch I cannot select and move the text. After applying the patch I am able to upload a image via drag n drop and also text can be selected and moved.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.

@N6REJ
Copy link
Contributor

N6REJ commented Oct 9, 2022

I have tested this item ✅ successfully on c683ae2

@Fedik Must have been. works fine today.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 9, 2022
@N6REJ
Copy link
Contributor

N6REJ commented Oct 9, 2022

RTC

@HLeithner HLeithner merged commit 5c484bd into joomla:4.2-dev Oct 15, 2022
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 15, 2022
@HLeithner HLeithner added this to the Joomla! 4.2.4 milestone Oct 15, 2022
@Fedik Fedik deleted the tiny-drag-fix branch October 15, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants