[4,2] remove JDEFAULT override for com_menus#38825
Merged
HLeithner merged 1 commit intojoomla:4.2-devfrom Sep 30, 2022
Merged
Conversation
see joomla#38815 Stops overriding the string JDEFAULT in com_menus and uses a dedicated string instead. Took longer to write this issue than it took to write a pull request.
Contributor
|
I have tested this item ✅ successfully on 952f0c6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38825. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 952f0c6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38825. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38825. |
HLeithner
reviewed
Sep 30, 2022
Member
|
thanks |
Contributor
Author
|
thanks |
Contributor
|
Thank you Brian |
Contributor
|
@brianteeman Something has changed Before this PR After this PR Is that intentional? See your PR #31694 |
Contributor
Author
|
bah humbug - forgot that. |
Contributor
|
I saw it only when comparing versions to update localization. Please add milestone 4.2.4 |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Oct 25, 2022
joomla/joomla-cms#37385 - (только для pl-PL) joomla/joomla-cms#38825 + joomla/joomla-cms#38877 - (только для других языков) joomla/joomla-cms#38867 + joomla/joomla-cms#37017 + joomla/joomla-cms#38771 + joomla/joomla-cms#38761 + joomla/joomla-cms#39072 - (только для en-GB) + исправление различных формулировок
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #38815
Stops overriding the string JDEFAULT in com_menus and uses a dedicated string instead.
Took longer to write this issue than it took to write a pull request.