Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Sep 21, 2022

Summary of Changes

When not logged in users can create articles, an exception is thrown that the article can not be checked out when saving it.

Testing Instructions

  • Set the create permission for the public user group to allowed.
  • Create a "Create Article" menu item
  • Open the front end as not logged in user
  • Go to the "Create Article" menu item
  • Set a title in the form
  • Click on the "Save" button (NOT "Save and Close")

Actual result BEFORE applying this Pull Request

"Argument 'userId' of event onTableBeforeCheckout must be an integer " error is displayed.

Expected result AFTER applying this Pull Request

FrontPage is loaded with text "Article submitted.".

@conseilgouz
Copy link
Contributor

Hi,

Any news about this PR ? it's marked "blocked"

@alikon
Copy link
Contributor

alikon commented Oct 14, 2022

as usual it needs test

@HDInfautre
Copy link

Hello
I have successfully tested this patch with patch tester


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38796.

@conseilgouz
Copy link
Contributor

I have tested this item ✅ successfully on 7c4fe6b

Joomla 4.2.3, PHP 8.1.5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38796.

@HDInfautre
Copy link

I have tested this item ✅ successfully on 7c4fe6b

Hello
I have successfully tested this patch with patch tester (joomla 4.2.3)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38796.

@alikon
Copy link
Contributor

alikon commented Oct 14, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38796.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 14, 2022
@HLeithner HLeithner merged commit 73abc86 into joomla:4.2-dev Oct 15, 2022
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot added Unit/System Tests and removed RTC This Pull Request is Ready To Commit labels Oct 15, 2022
@HLeithner HLeithner added this to the Joomla! 4.2.4 milestone Oct 15, 2022
@laoneo laoneo deleted the checkout/empty branch October 17, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants