Emptystate layout is used for non-empty cache#38671
Merged
obuisard merged 5 commits intojoomla:4.3-devfrom May 4, 2023
Merged
Conversation
Contributor
|
I can confirm the issue. Just wondering why its not the same as all the other emptystate with $this->get('IsEmptyState') |
Contributor
Author
|
@brianteeman Because |
Contributor
|
Ok. Thanks for the explanation |
Contributor
|
tested ok Its marked as an issue on the tracker so cant post a result there |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38671. |
Contributor
|
Thank you @Denitz :-) |
Contributor
Author
|
Thank you! 1-line patch in 10 months, even after Brian's confirmation :( |
Member
|
And this one line had a bug :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
"You have no cached content." is displayed after deleting the filtered cache group.
Testing Instructions
com_contentin search field.Actual result BEFORE applying this Pull Request
Frustrating "You have no cached content." message on active search filter applied though we have non-filtered cache groups.
Search field is not visible.
Expected result AFTER applying this Pull Request
See the usual empty table with "No Matching Results" message and visible search input.
Documentation Changes Required
No.