Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Aug 26, 2022

Pull Request for Issue # .

Summary of Changes

It is possible to add new modules to a dashboard. The dashboard name should be preselected in the position field, as it is a special position for every component (also for own components).
The PR adds the clientID to the position filter.

It was possible in former 4 versions but forgotten here #33763

Testing Instructions

Open any dashboard for example users.
Click the "add new module" button and select a module, the module is opened.

Actual result BEFORE applying this Pull Request

The position field shows "none"
grafik

You have to search for the right position in the list of possible positions

Expected result AFTER applying this Pull Request

In the position field the name of the active dashboard is preselected

grafik

Documentation Changes Required

@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on 2f138ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 2f138ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611.

@brianteeman
Copy link
Contributor

Thank you - this also closed #35153

@bembelimen
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2022
@wilsonge
Copy link
Contributor

Can we concat this into the existing string for readability? Otherwise we’re going to forget whether 1 is an array key or what in the future

@chmst
Copy link
Contributor Author

chmst commented Aug 27, 2022

With variable? @wilsonge

@fancyFranci fancyFranci merged commit 31bb856 into joomla:4.2-dev Sep 6, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2022
@fancyFranci
Copy link
Contributor

Thanks for finding and fixing this issue!

@fancyFranci fancyFranci added this to the Joomla! 4.2.3 milestone Sep 6, 2022
@chmst chmst deleted the cpanel-position-preselect branch September 9, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants