-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix position name in component dashboard #38611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have tested this item ✅ successfully on 2f138ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611. |
Contributor
|
I have tested this item ✅ successfully on 2f138ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611. |
Contributor
|
Thank you - this also closed #35153 |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611. |
Contributor
|
Can we concat this into the existing string for readability? Otherwise we’re going to forget whether 1 is an array key or what in the future |
Contributor
Author
|
With variable? @wilsonge |
wilsonge
reviewed
Aug 27, 2022
administrator/components/com_cpanel/src/Controller/DisplayController.php
Outdated
Show resolved
Hide resolved
wilsonge
reviewed
Aug 27, 2022
administrator/components/com_cpanel/src/Controller/DisplayController.php
Outdated
Show resolved
Hide resolved
wilsonge
reviewed
Aug 27, 2022
administrator/components/com_cpanel/src/Controller/DisplayController.php
Outdated
Show resolved
Hide resolved
…roller.php Co-authored-by: George Wilson <[email protected]>
…roller.php Co-authored-by: George Wilson <[email protected]>
…roller.php Co-authored-by: George Wilson <[email protected]>
Contributor
|
Thanks for finding and fixing this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
It is possible to add new modules to a dashboard. The dashboard name should be preselected in the position field, as it is a special position for every component (also for own components).
The PR adds the clientID to the position filter.
It was possible in former 4 versions but forgotten here #33763
Testing Instructions
Open any dashboard for example users.
Click the "add new module" button and select a module, the module is opened.
Actual result BEFORE applying this Pull Request
The position field shows "none"

You have to search for the right position in the list of possible positions
Expected result AFTER applying this Pull Request
In the position field the name of the active dashboard is preselected
Documentation Changes Required