Skip to content

Remove unused imports in MFA#38498

Merged
roland-d merged 2 commits intojoomla:4.2-devfrom
nikosdion:fix/38483-unused-import
Aug 18, 2022
Merged

Remove unused imports in MFA#38498
roland-d merged 2 commits intojoomla:4.2-devfrom
nikosdion:fix/38483-unused-import

Conversation

@nikosdion
Copy link
Contributor

Pull Request for Issue #38483 .

Summary of Changes

Removes unnecessary imports in com_users classes and view templates touched by the MFA feature.

This is a code quality PR @HLeithner @roland-d

Testing Instructions

Install a site and use the MFA feature.

Actual result BEFORE applying this Pull Request

Everything works.

Expected result AFTER applying this Pull Request

Everything still works.

Documentation Changes Required

None.

@HLeithner
Copy link
Member

Thanks but I think @fancyFranci should be mentioned here as release lead. Would expect that get merged after we have a stable 4.2 release.

@nikosdion
Copy link
Contributor Author

Thanks! I didn't have both their GitHub handles :)

@brianteeman
Copy link
Contributor

Thanks @nikosdion I was a bit scared to rely on my ide without fully understanding it to create the pr myself

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 53567ab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38498.

@nikosdion
Copy link
Contributor Author

@brianteeman You're welcome! This was easy for me, I could even tell why these use statements were left behind. I had started this as a standalone component, moved it to a com_users feature then went into two major refactoring rounds. The leftovers were indeed from the three refactoring rounds.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 53567ab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38498.

@zero-24 zero-24 added this to the Joomla! 4.2.1 milestone Aug 18, 2022
@roland-d roland-d merged commit 1f99d81 into joomla:4.2-dev Aug 18, 2022
@roland-d
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants