Remove unused imports in MFA#38498
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Aug 18, 2022
nikosdion:fix/38483-unused-import
Merged
Remove unused imports in MFA#38498roland-d merged 2 commits intojoomla:4.2-devfrom nikosdion:fix/38483-unused-import
roland-d merged 2 commits intojoomla:4.2-devfrom
nikosdion:fix/38483-unused-import
Conversation
Member
|
Thanks but I think @fancyFranci should be mentioned here as release lead. Would expect that get merged after we have a stable 4.2 release. |
Contributor
Author
|
Thanks! I didn't have both their GitHub handles :) |
Contributor
|
Thanks @nikosdion I was a bit scared to rely on my ide without fully understanding it to create the pr myself |
Contributor
|
I have tested this item ✅ successfully on 53567ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38498. |
Contributor
Author
|
@brianteeman You're welcome! This was easy for me, I could even tell why these |
Contributor
|
I have tested this item ✅ successfully on 53567ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38498. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38483 .
Summary of Changes
Removes unnecessary imports in com_users classes and view templates touched by the MFA feature.
This is a code quality PR @HLeithner @roland-d
Testing Instructions
Install a site and use the MFA feature.
Actual result BEFORE applying this Pull Request
Everything works.
Expected result AFTER applying this Pull Request
Everything still works.
Documentation Changes Required
None.