Skip to content

removed unused css #38353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2022
Merged

removed unused css #38353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1148bc
removed unused css
brianteeman Jul 31, 2022
507279a
update assets
brianteeman Jul 31, 2022
8598f33
Merge branch '4.3-dev' into edit_modules
obuisard Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions administrator/components/com_admin/script.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6440,6 +6440,7 @@ public function deleteUnexistingFiles($dryRun = false, $suppressOutput = false)
'/plugins/task/checkfiles/checkfiles.php',
'/plugins/task/demotasks/demotasks.php',
// From 4.2.0-rc1 to 4.2.0
'/build/media_source/com_menus/css/admin-item-edit_modules.css',
Copy link
Member

@richard67 richard67 Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is wrong. We do not remove things from /build/media_source on update!. We remove things from /media only. And it is in the wrong section // From 4.2.0-rc1 to 4.2.0 of the list. I will make a PR to fix both.

Copy link
Member

@richard67 richard67 Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is #39101 .

'/administrator/language/en-GB/plg_fields_menuitem.ini',
'/administrator/language/en-GB/plg_fields_menuitem.sys.ini',
'/plugins/fields/menuitem/menuitem.php',
Expand Down
3 changes: 1 addition & 2 deletions administrator/components/com_menus/tmpl/item/edit_modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@

/** @var Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->document->getWebAssetManager();
$wa->useStyle('com_menus.admin-item-edit-modules')
->useScript('com_menus.admin-item-edit-modules');
$wa->useScript('com_menus.admin-item-edit-modules');

// Set up the bootstrap modal that will be used for all module editors
echo HTMLHelper::_(
Expand Down
17 changes: 0 additions & 17 deletions build/media_source/com_menus/css/admin-item-edit_modules.css
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions build/media_source/com_menus/joomla.asset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@
"type": "module"
}
},
{
"name": "com_menus.admin-item-edit-modules",
"type": "style",
"uri": "com_menus/admin-item-edit_modules.min.css"
},
{
"name": "com_menus.admin-item-edit-modules.es5",
"type": "script",
Expand Down