Skip to content

Comments

fix replaceTags function for array#38305

Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom
keewhip:patch-2
Jan 22, 2023
Merged

fix replaceTags function for array#38305
fancyFranci merged 2 commits intojoomla:4.2-devfrom
keewhip:patch-2

Conversation

@keewhip
Copy link
Contributor

@keewhip keewhip commented Jul 20, 2022

Pull Request for Issue #38279.

Summary of Changes

If value to replace is an array, it is now replaced with the value
Like user custom fields

Testing Instructions

Create a user required custom field named testfield
Show this field on registration page
Include this field in the new user mailtemplate using the code {COM_FIELDS}testfield{/COM_FIELDS}
Register an new user account

Actual result BEFORE applying this Pull Request

The placeholder is replaced with a empty string

Expected result AFTER applying this Pull Request

The placeholder is replaced with the value submitted by the user

Documentation Changes Required

None

fix if value to replace is an array, like custom fields for user
#38279
@MacJoom
Copy link
Contributor

MacJoom commented Oct 22, 2022

I have tested this item ✅ successfully on a209ffb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38305.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on a209ffb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38305.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38305.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 21, 2023
@fancyFranci fancyFranci merged commit 94f78a4 into joomla:4.2-dev Jan 22, 2023
@fancyFranci fancyFranci added this to the Joomla! 4.2.7 milestone Jan 22, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 22, 2023
@fancyFranci
Copy link
Contributor

Thank you for fixing this bug!

@ReLater
Copy link
Contributor

ReLater commented Feb 10, 2023

This change has opened another issue. See #39774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants