fix replaceTags function for array#38305
Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom Jan 22, 2023
keewhip:patch-2
Merged
fix replaceTags function for array#38305fancyFranci merged 2 commits intojoomla:4.2-devfrom keewhip:patch-2
fancyFranci merged 2 commits intojoomla:4.2-devfrom
keewhip:patch-2
Conversation
fix if value to replace is an array, like custom fields for user #38279
Contributor
|
I have tested this item ✅ successfully on a209ffb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38305. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on a209ffb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38305. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38305. |
Contributor
|
Thank you for fixing this bug! |
Contributor
|
This change has opened another issue. See #39774 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38279.
Summary of Changes
If value to replace is an array, it is now replaced with the value
Like user custom fields
Testing Instructions
Create a user required custom field named testfield
Show this field on registration page
Include this field in the new user mailtemplate using the code {COM_FIELDS}testfield{/COM_FIELDS}
Register an new user account
Actual result BEFORE applying this Pull Request
The placeholder is replaced with a empty string
Expected result AFTER applying this Pull Request
The placeholder is replaced with the value submitted by the user
Documentation Changes Required
None