Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add GitHub token permissions for workflow #38256

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

varunsh-coder
Copy link
Contributor

Summary of Changes

This PR adds minimum token permissions for the GITHUB_TOKEN using https://github.com/step-security/secure-workflows.

GitHub recommends defining minimum GITHUB_TOKEN permissions for securing GitHub Actions workflows

This project is part of the top 100 critical projects as per OpenSSF (https://github.com/ossf/wg-securing-critical-projects), so fixing the token permissions to improve security.

Signed-off-by: Varun Sharma [email protected]

Testing Instructions

N/A

Actual result BEFORE applying this Pull Request

GITHUB_TOKEN has all permissions
https://github.com/joomla/joomla-cms/runs/7143497554?check_suite_focus=true#step:1:16

Expected result AFTER applying this Pull Request

GITHUB_TOKEN will have minimum permissions needed

Documentation Changes Required

N/A

@zero-24
Copy link
Contributor

zero-24 commented Jul 11, 2022

Looks good to me @wilsonge can you please double check here?

@wilsonge wilsonge merged commit 317263d into joomla:4.2-dev Jul 12, 2022
@wilsonge
Copy link
Contributor

LGTM. I'm not adding this to the release milestone as it just affects the .github directory. But feel free to overrule

@zero-24
Copy link
Contributor

zero-24 commented Jul 12, 2022

Thanks will assign to 3.10 as its a action that only runs for this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants