Skip to content

Comments

[4.4] package.json#38128

Closed
brianteeman wants to merge 7 commits intojoomla:4.4-devfrom
brianteeman:patch-5
Closed

[4.4] package.json#38128
brianteeman wants to merge 7 commits intojoomla:4.4-devfrom
brianteeman:patch-5

Conversation

@brianteeman
Copy link
Contributor

in another project I maintain we always update the version number here with each release

 in another project I maintain we always update the version number here with each release
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jun 22, 2022
@richard67
Copy link
Member

Shouldn't this then be done either by the build or by the bump script?

@brianteeman
Copy link
Contributor Author

yes it should be automated - if maintainers think it should be changed at all which I wasnt sure about as its never been updated

@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@HLeithner HLeithner removed the psr12 label Oct 23, 2022
@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Hackwar Hackwar added the bug label Apr 6, 2023
@brianteeman brianteeman changed the base branch from 4.2-dev to 4.4-dev April 21, 2023 21:03
@brianteeman brianteeman changed the title [4.2] package.json [4.4] package.json Apr 21, 2023
@brianteeman
Copy link
Contributor Author

rebased to 4.4

@Quy Quy removed the PR-4.2-dev label Apr 22, 2023
@laoneo
Copy link
Member

laoneo commented Apr 24, 2023

This should either be bumped with the bump script or removed all together as the CMS is not a library where other npm packages depend on.

@brianteeman
Copy link
Contributor Author

Updated as requested to be managed by the bump script #40513

@brianteeman brianteeman deleted the patch-5 branch April 30, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants