Skip to content

[4.2] Convert site status to service provider #38097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 20, 2022
Merged

[4.2] Convert site status to service provider #38097

merged 8 commits into from
Jun 20, 2022

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Jun 19, 2022

Summary of Changes

Convert the site status plugin to service provider.

Testing Instructions

  • Create three site status tasks for each type one
  • Run the task
  • Check the site status if it reflects the task type

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

heelc29
heelc29 reviewed Jun 19, 2022
View reviewed changes
@heelc29
Copy link
Contributor

heelc29 commented Jun 19, 2022

I have tested this item ✅ successfully on 4f75fc0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38097.

heelc29
heelc29 reviewed Jun 19, 2022
View reviewed changes
@roland-d roland-d merged commit fa4f287 into joomla:4.2-dev Jun 20, 2022
@roland-d roland-d deleted the j4/plugins/sitestatus branch June 20, 2022 18:51
@roland-d
Copy link
Contributor

Thank you guys

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 20, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted file from PR joomla#38097
72c3178
@richard67 richard67 mentioned this pull request Jun 20, 2022
Merged
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted file from PR joomla#38097
f7e5d9b
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted file from PR joomla#38097
31568c9
roland-d pushed a commit that referenced this pull request Jun 20, 2022
@richard67
[4.2] Update deleted files and folders for 4.2.0-beta2 (#38039)
8806607 
* Add deleted file from PR #37954

* Add deleted files from PR's #37928 , #37929 and #37947

* Add deleted files and folders from PR #38065

* Fix forgotten section header for folders

* Add deleted file from PR #38097
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted file from PR joomla#38097
db3acdb
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted file from PR joomla#38097
6d5fb98
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted file from PR joomla#38097
1d6fb8a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted file from PR joomla#38097
6ab173f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@heelc29 heelc29 heelc29 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Unit/System Tests

Projects

None yet

Milestone

Joomla! 4.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@laoneo @heelc29 @roland-d @joomla-cms-bot