[4.2] Adds a bunch of unit tests for the MVC layer #37955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

roland-d merged 43 commits into joomla:4.2-dev from Digital-Peak:j4/tests/mvc

Jun 3, 2022

Member

laoneo commented Jun 1, 2022

Summary of Changes

Adds a bunch of unit tests for the MVC layer.

Testing Instructions

Nothing as it mainly adds only unit tests.

laoneo added 25 commits

April 6, 2022 16:43


          Add interfaces for the objects who need a user

623921f

cs

f173723


          always default

87a9121


          Better desc

c40352f


          only set the current user when not null

ded765e


          Merge remote-tracking branch 'upstream/4.2-dev' into j4/user/current

80f4f0d


          tests

f29c086


          Merge branch '4.2-dev' into j4/user/current

e0b29ad


          Merge branch '4.2-dev' into j4/user/current

c991c7d


          Add unit tests

1d725b2


          version

bb3a382


          form model tests

e38faff


          since

829d830

cs

33dd209


          Controller test

db0685f


          make protected

5564c89


          Merge remote-tracking branch 'upstream/4.2-dev' into j4/tests/mvc

a219bff


          State behaviour test

069381e


          Base model test

3e1dd79


          adding more controller tests

d07261c


          Merge remote-tracking branch 'upstream/4.2-dev' into j4/tests/mvc

358ca10


          Merge remote-tracking branch 'upstream/4.2-dev' into j4/tests/mvc

21aa6dd


          more tests

8de7479


          item model test

e5ef0df


          Remove test that

94edae1

joomla-cms-bot added PR-4.2-dev Unit/System Tests labels


          Merge branch '4.2-dev' into j4/tests/mvc

6fbf554

brianteeman reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Controller/BaseControllerTest.php Outdated Show resolved Hide resolved

brianteeman reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Controller/BaseControllerTest.php Outdated Show resolved Hide resolved


          Update tests/Unit/Libraries/Cms/MVC/Controller/BaseControllerTest.php

bc3125a

Co-authored-by: Brian Teeman <[email protected]>

brianteeman reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Controller/BaseControllerTest.php Outdated Show resolved Hide resolved

brianteeman reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Model/BaseModelTest.php Outdated Show resolved Hide resolved

brianteeman reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Model/BaseModelTest.php Outdated Show resolved Hide resolved

brianteeman reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Model/BaseModelTest.php Outdated Show resolved Hide resolved

Doc

ecc81db

brianteeman reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Model/StateBehaviorTraitTest.php Outdated Show resolved Hide resolved

brianteeman reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Model/StateBehaviorTraitTest.php Outdated Show resolved Hide resolved

laoneo and others added 5 commits

June 1, 2022 16:45


          Update tests/Unit/Libraries/Cms/MVC/Model/StateBehaviorTraitTest.php

3503b2f

Co-authored-by: Brian Teeman <[email protected]>


          Update tests/Unit/Libraries/Cms/MVC/Model/StateBehaviorTraitTest.php

d4c95fb

Co-authored-by: Brian Teeman <[email protected]>

doc

3398c7c


          Merge remote-tracking branch 'origin/j4/tests/mvc' into j4/tests/mvc

ef8917b

doc

facc367

Member

richard67 commented Jun 1, 2022

Unit test in Appveyor (i.e. for Windows) is failing, see https://ci.appveyor.com/project/release-joomla/joomla-cms/builds/43726273 .

nibra reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Controller/BaseControllerTest.php Outdated Show resolved Hide resolved

nibra reviewed

View reviewed changes

tests/Unit/Libraries/Cms/MVC/Controller/BaseControllerTest.php Outdated Show resolved Hide resolved


          path

82e75a4

Member

richard67 commented Jun 2, 2022

@laoneo Now after you committed @nibra ‘s suggestions, all unit tests are failing on Linux and Windows (drone and appveyor)

laoneo and others added 9 commits

June 2, 2022 07:35


          Merge branch '4.2-dev' into j4/tests/mvc

6816d25


          DIRECTORY_SEPARATOR

1915abc

doc

8af0d09


          Abstract view

9e0c05f


          name

78cbb8f


          path

d10394b


          testdox combination with class

b2d5934


          Merge branch '4.2-dev' into j4/tests/mvc

fa81f8c


          Merge branch '4.2-dev' into j4/tests/mvc

ec716d6

roland-d merged commit f7b75a5 into joomla:4.2-dev

roland-d deleted the j4/tests/mvc branch

June 3, 2022 18:04

roland-d added this to the Joomla 4.2.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unit/System Tests