Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented May 30, 2022

Pull Request for Issue # .

Summary of Changes

Fix warning
Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in administrator\components\com_fields\src\Model\GroupModel.php on line 323

Testing Instructions

Add a new field group in com_contacts (php 8.1.5)

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

No deprecated warning

Documentation Changes Required

@chmst chmst added the PHP 8.x PHP 8.x deprecated issues label May 30, 2022
@toivo
Copy link
Contributor

toivo commented Jun 1, 2022

I have tested this item ✅ successfully on c94011d

Tested successfully in Joomla 4.1.5-dev of 1 June in Wampserver 3.2.9 using PHP 8.1.6.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37932.

@chmst
Copy link
Contributor Author

chmst commented Jun 1, 2022

@toivo could you please re-test?

@alikon
Copy link
Contributor

alikon commented Jun 1, 2022

I have tested this item ✅ successfully on df2a42d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37932.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on df2a42d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37932.

@Quy
Copy link
Contributor

Quy commented Jun 3, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37932.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 3, 2022
@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Jun 5, 2022
@bembelimen bembelimen merged commit 347f451 into joomla:4.1-dev Jun 5, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 5, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.5 milestone Jun 5, 2022
@chmst chmst deleted the com-fields-group-fix-warning branch June 5, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainers Checked Used if the PR is conceptional useful PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants