[4.2] task start scheduler on friend site via webcron #37878

alikon · 2022-05-24T14:26:52Z

Summary of Changes

Added a new task to start the scheduler on a friend site via Webcron

Testing Instructions

apply pr (on site A)
discover extension and install the new task plugin
enable the plugin

(on site B) site suppose that doesn't have crontab
enable the webcron

copy the link
enable some task ie (sleep) for example

on site (A)
create a new task WebCronStarter

and paste the URL copied before from (site B)
run the scheduler from cli for example
php cli/joomla.php scheduler:run

(on site B)
check that the task have been executed

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

you can schedule a task to start the scheduler on a friend site via webcron

Documentation Changes Required

plugins/task/webcronstart/webcronstart.xml

Co-authored-by: Konstantin Kolos <[email protected]>

richard67 · 2022-05-24T17:04:04Z

I can not see any SQL script changes in this PR to add the new plugin to the extensions table, neither in base.sql for new installation nor in a new update SQL script for updates.

alikon · 2022-05-24T17:08:21Z

i'll add...
but as it is , is testable, just discover

richard67 · 2022-05-24T17:12:02Z

i'll add...
but as it is , is testable, just discover

Yes, it is testable in this state … but not mergeable ;-)

richard67 · 2022-05-24T18:56:21Z

@alikon Regarding the update SQL scripts please look up in other update SQL scripts of the 4.2-dev branch how we add extensions, especially regarding the new INSERT IGNORE (MySQL) or ON CONFLICT DO NOTHING (PostgreSQL) which was introduced with PR #37156 , and also regarding columns which we do not use in update SQL scripts when inserting extensions.

Update: Silly me, that’s not needed here.

richard67 · 2022-05-24T19:03:59Z

@alikon In addition, make sure to use the right “ordering” values in the I sent statements in the update SQL script. The values should be the same as in base.sql, but currently they are different in your PR (16 in the update SQL versus 5 in base.sql).

alikon · 2022-05-24T19:13:50Z

@richard67 frankly speaking i don't think... those are "strictly" needed.
anyway feel free to enhance it, this pr is open

p.s
for the ordering field what I should do ?

richard67 · 2022-05-24T19:18:57Z

@richard67 frankly speaking i don't think... those are "strictly" needed. anyway feel free to enhance it, this pr is open

In my PR to which I referred to it is explained in detail why they were added, and it should not be a big thing for you to add that here, too. I am off my desk today and limited to mobile so I won’t be able to make a PR.

Update: Sorry for the confusion. I just see we don’t need that here in this case.

p.s for the ordering field what I should do ?

Use value 5 and not 16 in the update SQL script.

richard67 · 2022-05-24T19:21:53Z

@richard67 frankly speaking i don't think... those are "strictly" needed. anyway feel free to enhance it, this pr is open

@alikon I just see I was wrong, we do not need INSERT IGNORE here, it was for other cases where we used IDs. Sorry for the confusion.

richard67 · 2022-05-24T19:30:05Z

administrator/components/com_admin/sql/updates/mysql/4.2.0-2022-05-24.sql

@@ -0,0 +1,2 @@
+INSERT INTO `#__extensions` (`package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `locked`, `manifest_cache`, `params`, `custom_data`, `ordering`, `state`) VALUES
+(0, 'plg_task_webcronstart', 'plugin', 'webcronstart', 'task', 0, 1, 1, 0, 0, '', '{}', '', 16, 0);


Suggested change

(0, 'plg_task_webcronstart', 'plugin', 'webcronstart', 'task', 0, 1, 1, 0, 0, '', '{}', '', 16, 0);

(0, 'plg_task_webcronstart', 'plugin', 'webcronstart', 'task', 0, 1, 1, 0, 0, '', '{}', '', 5, 0);

why 5 ??
https://github.com/joomla/joomla-cms/blob/4.2-dev/administrator/components/com_admin/sql/updates/postgresql/4.1.0-2021-11-20.sql#L47-L53

-- Add plugins to "#__extensions" INSERT INTO "#__extensions" ("package_id", "name", "type", "element", "folder", "client_id", "enabled", "access", "protected", "locked", "manifest_cache", "params", "custom_data", "ordering", "state") VALUES (0, 'plg_system_schedulerunner', 'plugin', 'schedulerunner', 'system', 0, 1, 1, 0, 0, '', '{}', '', 15, 0), (0, 'plg_system_tasknotification', 'plugin', 'tasknotification', 'system', 0, 1, 1, 0, 1, '', '', '', 22, 0), (0, 'plg_task_checkfiles', 'plugin', 'checkfiles', 'task', 0, 1, 1, 0, 0, '', '{}', '', 15, 0), (0, 'plg_task_demotasks', 'plugin', 'demotasks', 'task', 0, 1, 1, 0, 0, '', '{}', '', 15, 0), (0, 'plg_task_requests', 'plugin', 'requests', 'task', 0, 1, 1, 0, 0, '', '{}', '', 15, 0), (0, 'plg_task_sitestatus', 'plugin', 'sitestatus', 'task', 0, 1, 1, 0, 0, '', '{}', '', 15, 0);

i've choosed 16 cause is bigger than 15

Hmm ... in base.sql all task scheduler plugins seem to have values 0 to 5. No idea why it was done differently in that update SQL script. Maybe someone else has an idea.

richard67 · 2022-05-24T19:31:08Z

administrator/components/com_admin/sql/updates/postgresql/4.2.0-2022-05-24.sql

@@ -0,0 +1,2 @@
+INSERT INTO "#__extensions" ("package_id", "name", "type", "element", "folder", "client_id", "enabled", "access", "protected", "locked", "manifest_cache", "params", "custom_data", "ordering", "state") VALUES
+(0, 'plg_task_webcronstart', 'plugin', 'webcronstart', 'task', 0, 1, 1, 0, 0, '', '{}', '', 16, 0);


Suggested change

(0, 'plg_task_webcronstart', 'plugin', 'webcronstart', 'task', 0, 1, 1, 0, 0, '', '{}', '', 16, 0);

(0, 'plg_task_webcronstart', 'plugin', 'webcronstart', 'task', 0, 1, 1, 0, 0, '', '{}', '', 5, 0);

toivo · 2022-05-25T06:47:13Z

After site A has the PR applied and the New Task plugin enabled the site crashes - JROOT\plugins\task\webcronstart\services\provider.php:49
An error has occurred.
0 syntax error, unexpected end of file, expecting ";"
#Fields: datetime priority clientip category message
2022-05-25T06:35:59+00:00 CRITICAL 127.0.0.1 error Uncaught Throwable of type ParseError thrown with message "syntax error, unexpected end of file, expecting ";"". Stack trace: #0 [ROOT]\libraries\src\Extension\ExtensionManagerTrait.php(94): Joomla\CMS\Application\CMSApplication->loadExtension('Joomla\CMS\Exte...', 'webcronstart:ta...', '[ROOT]...')

Did the following to get back to the back end:

removed blank link 49
changed line 48 from } to };
_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37878.}

alikon · 2022-05-25T06:59:40Z

good spot fixed

toivo · 2022-05-25T09:20:29Z

I have tested this item ✅ successfully on f9a26af

Tested successfully on two 4.2.0-beta1-dev of 25 May. The PR#37868] - [4.1] Fix generate web cron key was applied first in site B. Added to the CLI command the following arguments: --id 1 --verbose and received a normal response to the command prompt. Without --id 1 received the message "No tasks due!"

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37878.}

plugins/task/webcronstart/src/extension/Webcronstart.php

heelc29 · 2022-05-25T09:25:41Z

plugins/task/webcronstart/src/extension/forms/start_parameters.xml

+					name="url"
+					type="text"
+					label="PLG_TASK_WEBCRONSTART_URL_LABEL"
+					description="PLG_TASK_WEBCRONSTART_URL_DESC"
+					required="true"


Suggested change

name="url"

type="text"

label="PLG_TASK_WEBCRONSTART_URL_LABEL"

description="PLG_TASK_WEBCRONSTART_URL_DESC"

required="true"

name="url"

type="text"

label="PLG_TASK_WEBCRONSTART_URL_LABEL"

description="PLG_TASK_WEBCRONSTART_URL_DESC"

required="true"

heelc29 · 2022-05-25T09:26:09Z

plugins/task/webcronstart/webcronstart.xml

+		<language tag="en-GB">language/en-GB/plg_task_webcronstart.ini</language>
+		<language tag="en-GB">language/en-GB/plg_task_webcronstart.sys.ini</language>
+	</languages>
+</extension>


heelc29 · 2022-05-25T09:27:19Z

administrator/language/en-GB/plg_task_webcronstart.ini

+PLG_TASK_WEBCRONSTART_XML_DESCRIPTION="Start the webcron service for the friend site."
+PLG_TASK_WEBCRONSTART_URL_LABEL="Site URL"
+PLG_TASK_WEBCRONSTART_URL_DESC="The URL of the site to start the webcron service for."
+PLG_TASK_WEBCRONSTART_TITLE="WebCron Starter"
+PLG_TASK_WEBCRONSTART_DESC="Starts the WebCron service for the friend site."


Please alphasort and add EOF

heelc29 · 2022-05-25T09:27:27Z

administrator/language/en-GB/plg_task_webcronstart.sys.ini

+; Note : All ini files need to be saved as UTF-8
+
+PLG_TASK_WEBCRONSTART="Task - Start WebCron"
+PLG_TASK_WEBCRONSTART_XML_DESCRIPTION="Start the webcron service for the friend site."


heelc29 · 2022-05-25T09:28:45Z

plugins/task/webcronstart/src/extension/Webcronstart.php

+		// Let the request take longer than 300 seconds to avoid timeout issues
+		try
+		{
+			$response = HttpFactory::getHttp($options)->get($params->url, [], 300);


timeout parameter is not used here

Co-authored-by: heelc29 <[email protected]>

laoneo · 2022-05-25T09:40:21Z

I can't imagine a use case for a CMS where a remote web cron task should be executed on a regular basis. It is a CMS and not an administration panel. If it would be some kind of web hock feature for actions like an article save or user create, then ok. This plugin would be a perfect fit for the JED, but not for the core.

richard67 · 2022-05-25T09:58:38Z

@alikon Currently api and system tests are failing with loging in to backend after having made a new installation. The screenshot made from the failed login shows a syntax error, unexpected ')', unfortunately not with file and line number: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.2-dev/37878/system-tests/54571/InstallCest.configureJoomla.mysql.fail.png . I suggest you test that, make a new installation with your branch and then login to backend.

bembelimen · 2022-05-25T10:36:19Z

Just wondering, where is the difference to the "Get-Request" Task, which is already in the system?

alikon added 2 commits May 24, 2022 15:34

webcronstart

dd57bd3

languages

3e016c2

joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels May 24, 2022

alikon marked this pull request as ready for review May 24, 2022 14:27

Update provider.php

33e02ac

Kostelano reviewed May 24, 2022

View reviewed changes

plugins/task/webcronstart/webcronstart.xml Outdated Show resolved Hide resolved

Kostelano reviewed May 24, 2022

View reviewed changes

plugins/task/webcronstart/webcronstart.xml Outdated Show resolved Hide resolved

alikon and others added 3 commits May 24, 2022 17:39

Update plugins/task/webcronstart/webcronstart.xml

a9ad2db

Co-authored-by: Konstantin Kolos <[email protected]>

Update plugins/task/webcronstart/webcronstart.xml

7346e9d

Co-authored-by: Konstantin Kolos <[email protected]>

cs

30dc143

Merge branch '4.2-dev' into webcron-starter-task

97f91e8

alikon added 4 commits May 24, 2022 20:49

sql

4a31502

sql

31b1109

sql

9fe3383

sql

2f286c3

richard67 reviewed May 24, 2022

View reviewed changes

missed ;

f9a26af

heelc29 suggested changes May 25, 2022

View reviewed changes

Update plugins/task/webcronstart/src/extension/Webcronstart.php

86a58f9

Co-authored-by: heelc29 <[email protected]>

alikon closed this May 25, 2022

		@@ -0,0 +1,2 @@
		INSERT INTO `#__extensions` (`package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `locked`, `manifest_cache`, `params`, `custom_data`, `ordering`, `state`) VALUES
		(0, 'plg_task_webcronstart', 'plugin', 'webcronstart', 'task', 0, 1, 1, 0, 0, '', '{}', '', 16, 0);

		@@ -0,0 +1,2 @@
		INSERT INTO "#__extensions" ("package_id", "name", "type", "element", "folder", "client_id", "enabled", "access", "protected", "locked", "manifest_cache", "params", "custom_data", "ordering", "state") VALUES
		(0, 'plg_task_webcronstart', 'plugin', 'webcronstart', 'task', 0, 1, 1, 0, 0, '', '{}', '', 16, 0);

Uh oh!

[4.2] task start scheduler on friend site via webcron #37878

[4.2] task start scheduler on friend site via webcron #37878

Uh oh!

Conversation

alikon commented May 24, 2022

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Uh oh!

Uh oh!

Uh oh!

richard67 commented May 24, 2022

Uh oh!

alikon commented May 24, 2022

Uh oh!

richard67 commented May 24, 2022

Uh oh!

richard67 commented May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented May 24, 2022

Uh oh!

alikon commented May 24, 2022

Uh oh!

richard67 commented May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented May 24, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toivo commented May 25, 2022

Uh oh!

alikon commented May 25, 2022

Uh oh!

toivo commented May 25, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laoneo commented May 25, 2022

Uh oh!

richard67 commented May 25, 2022

Uh oh!

bembelimen commented May 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

richard67 commented May 24, 2022 •

edited

Loading

richard67 commented May 24, 2022 •

edited

Loading