[4] Fix for 37859. mod_feed. inline style and nonces.#37873
[4] Fix for 37859. mod_feed. inline style and nonces.#37873ReLater wants to merge 1 commit intojoomla:4.1-devfrom ReLater:patch-4
Conversation
|
I have tested this item ✅ successfully on ad83e0b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37873. |
|
Since modules can be loaded multiple times on a page (on a position and via loadmodule on an article) we should not have an |
|
@drmenzelit you have misunderstood that discussion |
|
The point at the end is that if the module have an id and you are loading the module twice, you will have duplicate ids in the code |
| ->addInlineStyle('#' . $modId . '{direction: ' . ($rssrtl ? 'rtl' :'ltr') . '};'); | ||
| ?> | ||
| <div style="direction: <?php echo $rssrtl ? 'rtl' :'ltr'; ?>;" class="text-<?php echo $rssrtl ? 'right' : 'left'; ?> feed"> | ||
| <div class="text-<?php echo $rssrtl ? 'right' : 'left'; ?> feed" id="<?php echo $modId; ?>"> |
There was a problem hiding this comment.
We probably need a class for it, and just switch .direction-ltr, .direction-rtl,
Or just use class with ID, then: '.' . $modId instead of '#' . $modId
|
Why did you close? |
|
Because it was open for 2 weeks now and I couldn't see any PR to my branch or a suggestion to add the wanted changes by click. |
8 participants
Fixes #37859
Testing Instructions
See opening post of issue #37859
Expected result AFTER applying this Pull Request
Feed output right aligned.