Skip to content

Conversation

@cyrez
Copy link
Contributor

@cyrez cyrez commented May 21, 2022

Improve Pull Request #37819 for Issue #37772

Summary of Changes

Following @nikosdion comment #35610 (comment) and #35610 (comment)

This PR removes the ability to set an attribute inlineHelp to the form field xml element.

I agree with @nikosdion on his statement, and so i have improved and simplified here my previous PR to only focus on fixing issue with hidden descriptions if no inlinehelp toggle button integrated.

Testing Instructions

Same as for previous PR #37819

  • Check if descriptions are hidden by default in com_config and com_content options.
  • Check if descriptions are shown by default everywhere else (where toggle button is not integrated) : component options, item edition, plugins manager... and in third-party extensions not integrating the toggle button.
  • Toggle button works as expected in com_config and com_content

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 12d9076

Everything still works well.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849.

@nikosdion
Copy link
Contributor

I approve of this change. Having been the one asking for it I am not sure if it's proper for me to provide a test? If so, let me know and I will.

@conseilgouz
Copy link
Contributor

I have tested this item ✅ successfully on 12d9076


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849.

@alikon
Copy link
Contributor

alikon commented May 28, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849.

@laoneo laoneo merged commit 5665ddb into joomla:4.1-dev Jun 3, 2022
@laoneo
Copy link
Member

laoneo commented Jun 3, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 3, 2022
@laoneo laoneo added this to the Joomla 4.1.5 milestone Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants