Skip to content

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented May 21, 2022

Pull Request for Issue # .

Summary of Changes

Update the lists of deleted files and folders in script.php to recent changes for the upcoming 4.2.0-alpha3:

  • Section "// From 4.1 to 4.2.0" of the $files list has been moved to the end of that list.
  • File "/modules/mod_articles_news/mod_articles_news.php" has been added to $files list. This file has been removed from the sources with PR [4.2] Introduce helper factory aware interface and convert news module to services #37445 .
  • File "/plugins/system/cache/cache.php" has been added to $files list. This file has been removed from the sources with PR Refactor the page cache plugin #36042 .
  • File "/libraries/vendor/nyholm/psr7/doc/final.md" and folder "/libraries/vendor/nyholm/psr7/doc" have been added to the corresponding lists. This file and the folder are not included anymore in the 3rd party composer dependency "nyholm/psr7" since it has been updated in the 4.2-dev branch with this commit: ceb4d81

Testing Instructions

Code review.

Or if you want to make a real test, update a 4.2.0-alpha2 or a 4.1.3 to the last 4.2 nightly build to get the actual result, and update a 4.2.0-alpha2 or a 4.1.3 to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

Files and folders mentioned in the description above are not deleted when updating from 4.2.0-alpha2 or 4.1.3.

Expected result AFTER applying this Pull Request

Files and folders mentioned in the description above are deleted when updating from 4.2.0-alpha2 or 4.1.3.

Documentation Changes Required

None.

@roland-d roland-d merged commit eb26a4a into joomla:4.2-dev May 21, 2022
@roland-d
Copy link
Contributor

Thank you.

@roland-d roland-d added this to the Joomla 4.2.0 milestone May 21, 2022
@richard67 richard67 deleted the 4.2-dev-update-deleted-files-and-folders-for-alpha-3 branch May 21, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants