Skip to content

Moving Joomla part on the update notice form com_installer to com_joomlaupdate#3779

Merged
infograf768 merged 6 commits intojoomla:stagingfrom
zero-24:patch-1
Jul 10, 2014
Merged

Moving Joomla part on the update notice form com_installer to com_joomlaupdate#3779
infograf768 merged 6 commits intojoomla:stagingfrom
zero-24:patch-1

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Jun 14, 2014

@brianteeman Please have a look here.

This based on your comment here: #3775 (comment)

If you good with it we can create a tracker for it.

Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be either
Before updating Joomla!, ensure that the installed extensions are available for the new Joomla! version."
or
Before you update Joomla!, ensure that the installed extensions are available for the new Joomla! version."

@zero-24
Copy link
Contributor Author

zero-24 commented Jun 14, 2014

Thanks @brianteeman i choose the second on. 👍

@zero-24
Copy link
Contributor Author

zero-24 commented Jun 15, 2014

Tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33867&start=0

@note if JC is back we need to move the JC Tracker to pending

@ghost
Copy link

ghost commented Jun 25, 2014

@test
Works as expected
jupdate

@brianteeman
Copy link
Contributor

Looks good to me - thanks for coding this

@roland-d
Copy link
Contributor

@test: Works as described.

I do get a CS issue when I apply the patch:

:20: trailing whitespace.
// Show the message if a update is found
warning: 1 line adds whitespace errors.

Please fix this before moving to RTC. Thanks.

@zero-24
Copy link
Contributor Author

zero-24 commented Jun 28, 2014

thanks @roland-d should fixed now with zero-24@beb3f32

@roland-d
Copy link
Contributor

@zero-24 Indeed, all good now.

infograf768 added a commit that referenced this pull request Jul 10, 2014
Moving Joomla part on the update notice form com_installer to com_joomlaupdate
@infograf768 infograf768 merged commit bbad81b into joomla:staging Jul 10, 2014
@zero-24 zero-24 deleted the patch-1 branch July 21, 2014 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants