Fixed ReCaptcha position in user registration form#37705
Fixed ReCaptcha position in user registration form#37705shazmasiddiqui wants to merge 14 commits intojoomla:4.3-devfrom shazmasiddiqui:recaptcha-position
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
|
@shazmasiddiqui Check our coding standards: https://developer.joomla.org/coding-standards/introduction.html . And a useful hint: Adjust your editor in a way so that you can see and distinguish tabs and spaces. |
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
@richard67 Thankyou for your helpful suggestions. I will keep these suggestions in mind for my next PR's. |
|
@shazmasiddiqui You don't always need to update your branch when it is shown as not up to date with the base branch on GitHub. You only need to do that when GitHub shows that there are conflicting files, which was not the case. |
Co-authored-by: Quy <quy@fluxbb.org>
|
This pull requests has automatically rebased to 4.2-dev. |
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
|
This pull request has been automatically rebased to 4.3-dev. |
|
Shazma @shazmasiddiqui, does the PR #38604 fix the issue? |
|
This has been addressed with #38604. |
Pull Request for Issue #37698
Testing Instructions
Enable ReCaptcha and custom fields in registration form and check the position of ReCaptcha. It should be placed at the bottom of the form, right before Register button.
Actual result BEFORE applying this Pull Request
The ReCaptcha is placed before custom fields, in the middle of the form
Expected result AFTER applying this Pull Request
The ReCaptcha should be placed before the Register button