Skip to content

Fixed ReCaptcha position in user registration form#37705

Closed
shazmasiddiqui wants to merge 14 commits intojoomla:4.3-devfrom
shazmasiddiqui:recaptcha-position
Closed

Fixed ReCaptcha position in user registration form#37705
shazmasiddiqui wants to merge 14 commits intojoomla:4.3-devfrom
shazmasiddiqui:recaptcha-position

Conversation

@shazmasiddiqui
Copy link
Contributor

Pull Request for Issue #37698

Testing Instructions

Enable ReCaptcha and custom fields in registration form and check the position of ReCaptcha. It should be placed at the bottom of the form, right before Register button.

Actual result BEFORE applying this Pull Request

The ReCaptcha is placed before custom fields, in the middle of the form

Expected result AFTER applying this Pull Request

The ReCaptcha should be placed before the Register button

shazmasiddiqui and others added 5 commits May 1, 2022 15:58
@richard67
Copy link
Member

@shazmasiddiqui Check our coding standards: https://developer.joomla.org/coding-standards/introduction.html . And a useful hint: Adjust your editor in a way so that you can see and distinguish tabs and spaces.

shazmasiddiqui and others added 2 commits May 1, 2022 17:35
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@shazmasiddiqui
Copy link
Contributor Author

@richard67 Thankyou for your helpful suggestions. I will keep these suggestions in mind for my next PR's.

@richard67
Copy link
Member

@shazmasiddiqui You don't always need to update your branch when it is shown as not up to date with the base branch on GitHub. You only need to do that when GitHub shows that there are conflicting files, which was not the case.

@HLeithner HLeithner changed the base branch from 4.1-dev to 4.2-dev June 27, 2022 13:05
@HLeithner
Copy link
Member

This pull requests has automatically rebased to 4.2-dev.

@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@HLeithner HLeithner removed the psr12 label Oct 23, 2022
@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Hackwar Hackwar added the bug label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 4.3-dev May 2, 2023 16:30
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.3-dev.

@obuisard
Copy link
Contributor

obuisard commented Jun 2, 2023

Shazma @shazmasiddiqui, does the PR #38604 fix the issue?

@obuisard
Copy link
Contributor

obuisard commented Jun 9, 2023

This has been addressed with #38604.
Thank you for your PR!

@obuisard obuisard closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Small A PR which only has a small change

Projects

None yet

Development

Successfully merging this pull request may close these issues.