[4.1] com_privacy site router is not working#37602
Merged
laoneo merged 2 commits intojoomla:4.1-devfrom Apr 23, 2022
Merged
Conversation
laoneo
approved these changes
Apr 22, 2022
|
I have tested this item ✅ successfully on f14f8fd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602. |
1 similar comment
|
I have tested this item ✅ successfully on f14f8fd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602. |
Contributor
|
Thank you @kiki-G for testing! The PR needs a second test from another person to be RTC. |
Member
|
I have tested this item ✅ successfully on f14f8fd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602. |
Member
|
Setting again RTC in the issue tracker because that doesn't have it yet. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Implement router service in privacy component
Testing Instructions
Create a menu link eg for Privacy » Create Request (alias: privacy-request)
Actual result BEFORE applying this Pull Request
Link of menu item:
/index.php/privacy-request?view=requestExpected result AFTER applying this Pull Request
Link of menu item:
/index.php/privacy-requestDocumentation Changes Required
none