Skip to content

[4.1] com_privacy site router is not working#37602

Merged
laoneo merged 2 commits intojoomla:4.1-devfrom
heelc29:issue-privacy-siterouter
Apr 23, 2022
Merged

[4.1] com_privacy site router is not working#37602
laoneo merged 2 commits intojoomla:4.1-devfrom
heelc29:issue-privacy-siterouter

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 22, 2022

Summary of Changes

Implement router service in privacy component

Testing Instructions

Create a menu link eg for Privacy » Create Request (alias: privacy-request)

Actual result BEFORE applying this Pull Request

Link of menu item: /index.php/privacy-request?view=request

Expected result AFTER applying this Pull Request

Link of menu item: /index.php/privacy-request

Documentation Changes Required

none

@laoneo laoneo added the Maintainers Checked Used if the PR is conceptional useful label Apr 22, 2022
@richard67 richard67 added PBF Pizza, Bugs and Fun labels Apr 22, 2022
@kiki-G
Copy link

kiki-G commented Apr 22, 2022

I have tested this item ✅ successfully on f14f8fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602.

1 similar comment
@kiki-G
Copy link

kiki-G commented Apr 22, 2022

I have tested this item ✅ successfully on f14f8fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602.

@chmst
Copy link
Contributor

chmst commented Apr 22, 2022

Thank you @kiki-G for testing! The PR needs a second test from another person to be RTC.

@RickR2H
Copy link
Member

RickR2H commented Apr 22, 2022

I have tested this item ✅ successfully on f14f8fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602.

@joomla-cms-bot joomla-cms-bot removed PBF Pizza, Bugs and Fun PR-4.1-dev Maintainers Checked Used if the PR is conceptional useful labels Apr 22, 2022
@RickR2H
Copy link
Member

RickR2H commented Apr 22, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602.

@RickR2H RickR2H added RTC This Pull Request is Ready To Commit PBF Pizza, Bugs and Fun PR-4.1-dev Maintainers Checked Used if the PR is conceptional useful labels Apr 22, 2022
@richard67 richard67 removed RTC This Pull Request is Ready To Commit PBF Pizza, Bugs and Fun PR-4.1-dev Maintainers Checked Used if the PR is conceptional useful labels Apr 23, 2022
@richard67
Copy link
Member

Setting again RTC in the issue tracker because that doesn't have it yet.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37602.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 23, 2022
@richard67 richard67 added PBF Pizza, Bugs and Fun PR-4.1-dev Maintainers Checked Used if the PR is conceptional useful labels Apr 23, 2022
@laoneo laoneo merged commit b07d1e5 into joomla:4.1-dev Apr 23, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 23, 2022
@laoneo
Copy link
Member

laoneo commented Apr 23, 2022

Thanks!

@laoneo laoneo added this to the Joomla 4.1.3 milestone Apr 23, 2022
@heelc29 heelc29 deleted the issue-privacy-siterouter branch April 23, 2022 19:35
@richard67 richard67 removed the PBF Pizza, Bugs and Fun label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainers Checked Used if the PR is conceptional useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants