Show loading view in installer component properly#37570
Merged
laoneo merged 2 commits intojoomla:4.1-devfrom Apr 19, 2022
Merged
Show loading view in installer component properly#37570laoneo merged 2 commits intojoomla:4.1-devfrom
laoneo merged 2 commits intojoomla:4.1-devfrom
Conversation
Member
|
I have tested this item ✅ successfully on 01bed1d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570. |
Member
|
@brianteeman Could you test this PR, too? It's the same as #37538 , but this time for the 4.1-dev branch. Thanks in advance. |
Contributor
|
I have tested this item ✅ successfully on 01bed1d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570. |
Member
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37516
Note: this PR is the rebase to 4.1-dev for this PR: #37538 (had to create a new one because I messed something up on the other one)
Summary of Changes
When removing the "hidden" class from the loading view in the installer component in the inspector, this view is now properly positioned
Testing Instructions
Go to the extension installer, open the inspector and search for the div with the ID "loading", then remove the "hidden" class from it
Actual result BEFORE applying this Pull Request
The loading view was positioned below the main content and was invisible
Expected result AFTER applying this Pull Request
The loading view is now visible and properly positioned
Documentation Changes Required
None