Skip to content

Show loading view in installer component properly#37570

Merged
laoneo merged 2 commits intojoomla:4.1-devfrom
magnussinger:i37516-4.1
Apr 19, 2022
Merged

Show loading view in installer component properly#37570
laoneo merged 2 commits intojoomla:4.1-devfrom
magnussinger:i37516-4.1

Conversation

@magnussinger
Copy link
Contributor

Pull Request for Issue #37516

Note: this PR is the rebase to 4.1-dev for this PR: #37538 (had to create a new one because I messed something up on the other one)

Summary of Changes

When removing the "hidden" class from the loading view in the installer component in the inspector, this view is now properly positioned

Testing Instructions

Go to the extension installer, open the inspector and search for the div with the ID "loading", then remove the "hidden" class from it

Actual result BEFORE applying this Pull Request

The loading view was positioned below the main content and was invisible

Expected result AFTER applying this Pull Request

The loading view is now visible and properly positioned

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Apr 17, 2022
@richard67
Copy link
Member

I have tested this item ✅ successfully on 01bed1d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570.

@richard67
Copy link
Member

@brianteeman Could you test this PR, too? It's the same as #37538 , but this time for the 4.1-dev branch. Thanks in advance.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 01bed1d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 17, 2022
@laoneo laoneo merged commit 6203707 into joomla:4.1-dev Apr 19, 2022
@laoneo
Copy link
Member

laoneo commented Apr 19, 2022

Thanks!!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 19, 2022
@zero-24 zero-24 added this to the Joomla 4.1.3 milestone Apr 19, 2022
@laoneo laoneo mentioned this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants