Skip to content

[4.1] Update input dependency which contains PHP 8.1 fixes#37502

Merged
bembelimen merged 2 commits intojoomla:4.1-devfrom
Digital-Peak:j4/input/update
Apr 13, 2022
Merged

[4.1] Update input dependency which contains PHP 8.1 fixes#37502
bembelimen merged 2 commits intojoomla:4.1-devfrom
Digital-Peak:j4/input/update

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Apr 7, 2022

Pull Request for part of Issue #37274 and #34952.

Summary of Changes

Update the input package with the recent PHP 8.1 fixes.

Testing Instructions

  • Use PHP 8.1
  • Set error reporting to maximum in the global Joomla configuration
  • Open the back end dash board

Actual result BEFORE applying this Pull Request

The following error is displayed:
Deprecated: Return type of Joomla\Input\Input::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
/libraries/vendor/joomla/input/src/Input.php

Expected result AFTER applying this Pull Request

No error.

@laoneo laoneo added the PHP 8.x PHP 8.x deprecated issues label Apr 7, 2022
This was referenced Apr 7, 2022
@exstreme
Copy link

exstreme commented Apr 7, 2022

I have tested this item ✅ successfully on 3cbf26f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37502.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Apr 7, 2022

I have tested this item ✅ successfully on 3cbf26f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37502.

@alikon
Copy link
Contributor

alikon commented Apr 7, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37502.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 7, 2022
@bembelimen bembelimen merged commit 3d90c16 into joomla:4.1-dev Apr 13, 2022
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 13, 2022
@bembelimen bembelimen added this to the Joomla 4.1.3 milestone Apr 13, 2022
@laoneo laoneo deleted the j4/input/update branch April 13, 2022 05:56
@Quy Quy mentioned this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants