Skip to content

[4.1] Use to PHP 8.1 fixes for debug bar dependency#37488

Merged
wilsonge merged 7 commits intojoomla:4.1-devfrom
Digital-Peak:j4/deug/bar-81
Apr 13, 2022
Merged

[4.1] Use to PHP 8.1 fixes for debug bar dependency#37488
wilsonge merged 7 commits intojoomla:4.1-devfrom
Digital-Peak:j4/deug/bar-81

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Apr 5, 2022

Pull Request for Issue #37274.

Summary of Changes

Updates the PHP debugbar dependency to the commit with the latest PHP 8.1 fixes. It is basically the release 1.18.0 with the fixes.

Testing Instructions

  • Run Joomla on PHP 8.1
  • Enable debugging in the global Joomla configuration
  • Set error reporting to maximum in the global Joomla configuration
  • Make sure the debug plugin is enabled by default (is the case when doing a new installation)

Actual result BEFORE applying this Pull Request

The following error is shown:
Implicit conversion from float -INF to int loses precision in

Expected result AFTER applying this Pull Request

No error.

@laoneo laoneo changed the title Use to PHP 8.1 fixes for debug bar dependency [4.1] Use to PHP 8.1 fixes for debug bar dependency Apr 5, 2022
@laoneo laoneo mentioned this pull request Apr 7, 2022
@exstreme
Copy link

exstreme commented Apr 7, 2022

I have tested this item ✅ successfully on 1918150


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488.

@HLeithner
Copy link
Member

Can you please pin the commit and not the branch. thx

@laoneo
Copy link
Member Author

laoneo commented Apr 13, 2022

I did that in my first commit 662e140 and then composer complained that that it is unsafe to do this and did abort on drone. The lock file is actually pointing to the commit, so we are covered to some degree.

@chmst
Copy link
Contributor

chmst commented Apr 13, 2022

I have tested this item ✅ successfully on ccae245

Tested on branch 4.1-dev,win11, xampp, php 8.1, debug mode "on" and error-reporting="maximum".

Before Patch: the application crashed with an eror 500, but not the message wich is mentioned in testing instructions.

After patch: application runs, no errors, no deprecated warnings.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488.

@laoneo
Copy link
Member Author

laoneo commented Apr 13, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 13, 2022
@wilsonge wilsonge merged commit 99ce07f into joomla:4.1-dev Apr 13, 2022
@wilsonge wilsonge deleted the j4/deug/bar-81 branch April 13, 2022 18:47
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 13, 2022
@wilsonge wilsonge added this to the Joomla 4.1.3 milestone Apr 13, 2022
@wilsonge
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants