[4.1] Use to PHP 8.1 fixes for debug bar dependency#37488
Merged
wilsonge merged 7 commits intojoomla:4.1-devfrom Apr 13, 2022
Merged
[4.1] Use to PHP 8.1 fixes for debug bar dependency#37488wilsonge merged 7 commits intojoomla:4.1-devfrom
wilsonge merged 7 commits intojoomla:4.1-devfrom
Conversation
Closed
|
I have tested this item ✅ successfully on 1918150 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488. |
Member
|
Can you please pin the commit and not the branch. thx |
Member
Author
|
I did that in my first commit 662e140 and then composer complained that that it is unsafe to do this and did abort on drone. The lock file is actually pointing to the commit, so we are covered to some degree. |
Contributor
|
I have tested this item ✅ successfully on ccae245 Before Patch: the application crashed with an eror 500, but not the message wich is mentioned in testing instructions. After patch: application runs, no errors, no deprecated warnings. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37274.
Summary of Changes
Updates the PHP debugbar dependency to the commit with the latest PHP 8.1 fixes. It is basically the release 1.18.0 with the fixes.
Testing Instructions
Actual result BEFORE applying this Pull Request
The following error is shown:
Implicit conversion from float -INF to int loses precision in
Expected result AFTER applying this Pull Request
No error.