Skip to content

[4.1] webauthn table accessibility #37464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2022
Merged

[4.1] webauthn table accessibility #37464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aad0a0c
[4.1] webauthn table accessibility
brianteeman Apr 3, 2022
724a7be
Merge branch '4.1-dev' into webauthntable
brianteeman Apr 3, 2022
0f40fc9
Merge branch '4.1-dev' into webauthntable
Apr 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions administrator/language/en-GB/plg_system_webauthn.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ PLG_SYSTEM_WEBAUTHN_MANAGE_HEADER_NOMETHODS_LABEL="No authenticators have been s
PLG_SYSTEM_WEBAUTHN_MSG_DELETED="The authenticator has been removed."
PLG_SYSTEM_WEBAUTHN_MSG_SAVED_LABEL="The label has been saved."
PLG_SYSTEM_WEBAUTHN_REQUIRES_GMP="Either of the PHP extensions GMP or BCmath must be loaded to add authenticators."
PLG_SYSTEM_WEBAUTHN_TABLE_CAPTION="Table of WebAuthn authenticators."
9 changes: 6 additions & 3 deletions layouts/plugins/system/webauthn/manage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,17 +98,20 @@
<?php endif; ?>

<table class="table table-striped">
<caption class="visually-hidden">
<?php echo Text::_('PLG_SYSTEM_WEBAUTHN_TABLE_CAPTION'); ?>,
</caption>
<thead class="table-dark">
<tr>
<th><?php echo Text::_('PLG_SYSTEM_WEBAUTHN_MANAGE_FIELD_KEYLABEL_LABEL') ?></th>
<th><?php echo Text::_('PLG_SYSTEM_WEBAUTHN_MANAGE_HEADER_ACTIONS_LABEL') ?></th>
<th scope="col"><?php echo Text::_('PLG_SYSTEM_WEBAUTHN_MANAGE_FIELD_KEYLABEL_LABEL') ?></th>
<th scope="col"><?php echo Text::_('PLG_SYSTEM_WEBAUTHN_MANAGE_HEADER_ACTIONS_LABEL') ?></th>
</tr>
</thead>
<tbody>
<?php // phpcs:ignore
foreach ($credentials as $method): ?>
<tr data-credential_id="<?php echo $method['id'] ?>">
<td><?php echo htmlentities($method['label']) ?></td>
<th scope="row"><?php echo htmlentities($method['label']) ?></th>
<td>
<button data-random-id="<?php echo $randomId; ?>" class="plg_system_webauthn-manage-edit btn btn-secondary">
<span class="icon-edit" aria-hidden="true"></span>
Expand Down