[4.x] Name attribute in xml - code style#37387
Merged
Quy merged 3 commits intojoomla:4.1-devfrom Apr 1, 2022
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 9ff9d26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37387. |
1 similar comment
|
I have tested this item ✅ successfully on 9ff9d26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37387. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37387. |
Contributor
|
Thanks |
obuisard
pushed a commit
to obuisard/joomla-cms
that referenced
this pull request
Feb 21, 2023
* fix EOF * fix filter forms fix default sort sort order dropdown like table columns fix sort state ->published * fix manifest lowercase name (see. joomla#37387) indentation (spaces vs. tabs) * cleanup component provider component do not use SiteRouter and Category
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the
<name>elements in the xml files use lowercase except for these two.Doesn't break anything having these in a different case but it does look odd when you look at the #__extensions table
Code review should be enough