[4.1] Adapt deleted files list in script.php to PR 37382 #37383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 3.10.7-2022-02-20.sql to deleted files in script.php where it is missing
richard67
changed the title
Member
Author
|
Adding the release blocker label because when #37382 is merged into 3.10-dev (and it should because it is also a release blocker), then it needs this PR here for 4.10 and 4.2, otherwise if the file is not deleted in might run under certain conditions by the updater, and that could cause a problem. |
Contributor
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Add 3.10.7-2022-02-20.sql to deleted files in script.php where it is missing.
When PR #37382 will bee merged into the 3.10-dev branch and that change will be released, we have to delete the update SQL scripts with the right name, too.
So this PR here adds them to the list in script.php.
For mysql it does not need that change because there the file name was right from the beginning in the 3.10-dev branch.
Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
Only the "3.10.7-2022-03-18.sql" file for mysql will be deleted after an update from next 3.10.7 to 4.1, the files for postgresql and sqlazure will remain.
Expected result AFTER applying this Pull Request
Files "3.10.7-2022-03-18.sql" will be deleted after an update from next 3.10.7 to 4.1.
Documentation Changes Required
None.