Formatted the calendar widget#36995
Conversation
joomla-cms-bot
added
NPM Resource Changed
akshitrattan
changed the title
| .buttons-wrapper .btn:last-child { | ||
| margin-right: 0; | ||
| } | ||
| /* .time { |
There was a problem hiding this comment.
please do not commit commented out code1
There was a problem hiding this comment.
sorry about that, I made the changes
| z-index: 1100 !important; | ||
| } | ||
| .calendar-container table { | ||
| margin: 0px 0px 0px 55px; |
There was a problem hiding this comment.
when the value is 0 then you should not put any units
| margin: 0px 0px 0px 55px; | |
| margin: 0 0 0 55px; |
There was a problem hiding this comment.
Would it not be better to use a margin: 0 auto; instead of setting a hard amount?
There was a problem hiding this comment.
Would it not be better to use a
margin: 0 auto;instead of setting a hard amount?
there is an empty td element in the entire 'time' row so setting the attribute to auto won't work
There was a problem hiding this comment.
I don't see how the empty td element would be affecting the alignment of the table itself, that td should only be affecting that row. When I submitted the original issue, I noted all of the inline edits I made and margin: 0 auto; on the table had no negative impact when tested. Granted, I do not know if how to script builds the popup+table would be affected by auto, so if something there does affect it, ignore my suggestion.
|
This pull request has automatically rebased to 4.2-dev. |
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
|
I have tested this item ✅ successfully on 259bc23 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36995. |
|
This pull request has been automatically rebased to 4.3-dev. |
|
I have tested this item ✅ successfully on cfef221 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36995. |
|
I have tested this item 🔴 unsuccessfully on cfef221 I've set my test as unsuccessfully, as the colspan changes may have issues depending on the form field settings (with or without weeknumbers, am/pm...) You can check my PR #40761 and see what i did there (with a bit more styling for other elements, such as footer buttons) ;-) Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36995. |
|
Thank you Akshit @akshitrattan for this PR. After review, I think this is not flexible enough and results may vary depending on the languages used. I am closing the PR in favor of PR #40761. |
14 participants
Pull Request for Issue #36933 .
Summary of Changes
solved issue number 3/3.
Stylized the time drop-down menu according to bootstrap 4 and centred the calendar table in the widget for the calendar to look more symmetrical
Testing Instructions
Open the calendar widget in any of the tabs you wish to, notice the change in the buttons from the previous versions
Actual result BEFORE applying this Pull Request
calendar looked like this
Expected result AFTER applying this Pull Request
it should look like this
Documentation Changes Required
No changes required