[4.1] Finder: Translate taxonomy titles in search results#36863
Merged
bembelimen merged 2 commits intojoomla:4.1-devfrom Feb 21, 2022
Merged
[4.1] Finder: Translate taxonomy titles in search results#36863bembelimen merged 2 commits intojoomla:4.1-devfrom
bembelimen merged 2 commits intojoomla:4.1-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 7e58afa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 7e58afa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863. |
Contributor
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #34841.
Summary of Changes
The taxonomy names are not translated in the search results so far. Since we do translate them in the search form, it's just a matter of adding the right code. Please note that not all taxonomies types are always translated. It is expected that you provide translation overrides where necessary and to fix additional issues around this, there is #36748.
Testing Instructions
Actual result BEFORE applying this Pull Request
The taxonomies are listed, but the missins asterisks (*) show, that the strings aren't translated.
Expected result AFTER applying this Pull Request
The taxonomies are listed and now are either wrapped in asterisks or even show translation keys.
Note
I strongly suggest to only merge this when also #36748 is merged.