Skip to content

[4.1] Finder: Translate taxonomy titles in search results#36863

Merged
bembelimen merged 2 commits intojoomla:4.1-devfrom
Hackwar:4.1-finder-taxonomylang
Feb 21, 2022
Merged

[4.1] Finder: Translate taxonomy titles in search results#36863
bembelimen merged 2 commits intojoomla:4.1-devfrom
Hackwar:4.1-finder-taxonomylang

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 26, 2022

Pull Request for Issue #34841.

Summary of Changes

The taxonomy names are not translated in the search results so far. Since we do translate them in the search form, it's just a matter of adding the right code. Please note that not all taxonomies types are always translated. It is expected that you provide translation overrides where necessary and to fix additional issues around this, there is #36748.

Testing Instructions

  1. Setup a site with content and smart search
  2. Enable debugging together with language debugging.
  3. Search in the frontend for something.

Actual result BEFORE applying this Pull Request

The taxonomies are listed, but the missins asterisks (*) show, that the strings aren't translated.

Expected result AFTER applying this Pull Request

The taxonomies are listed and now are either wrapped in asterisks or even show translation keys.

Note

I strongly suggest to only merge this when also #36748 is merged.

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 7e58afa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jan 29, 2022

I have tested this item ✅ successfully on 7e58afa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863.

@Quy
Copy link
Contributor

Quy commented Jan 29, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 29, 2022
@bembelimen bembelimen added this to the Joomla 4.1.1 milestone Jan 31, 2022
@bembelimen bembelimen merged commit 6e71102 into joomla:4.1-dev Feb 21, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 21, 2022
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants