Skip to content

[4.1] order formdata#36353

Merged
roland-d merged 8 commits intojoomla:4.1-devfrom
dgrammatiko:4.1-dev-order-formdata
Apr 22, 2022
Merged

[4.1] order formdata#36353
roland-d merged 8 commits intojoomla:4.1-devfrom
dgrammatiko:4.1-dev-order-formdata

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue #36346 .

Summary of Changes

Send all the form data (although it's useless as you only need the changed id's for reordering) to the PHP

Testing Instructions

  • The core still works as before because it doesn't need any extra data

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Documentation Changes Required

@brianteeman

This comment has been minimized.

@dgrammatiko
Copy link
Contributor Author

impossible to test

Well, we can confirm that the core still works as expected so that the core is not broken but these changes. The extra bits on the payload would be useful for devs doing things out of the core API and that's untestable but also should be ok if we didn't broke the core extensions...

@PhocaCz
Copy link
Contributor

PhocaCz commented Dec 20, 2021

To test it: Use browser with DevTools enabled (e.g. Google Chrome). Create articles and sort them. In DevTools switch to Network tab, to "Fetch/XHR" tab and see the AJAX results (see image):

img

When the patch is not applied, you will see only cid and order variable.

When the patch is applied, you will see more form data available. When you see them, you can mark this test as successfull.

Jan

@PhocaCz
Copy link
Contributor

PhocaCz commented Dec 20, 2021

I have tested this item ✅ successfully on d88638c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36353.

@jwaisner jwaisner added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jan 3, 2022
@jwaisner
Copy link
Member

jwaisner commented Jan 3, 2022

@dgrammatiko

Please update the PR to the latest branch.

@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jan 17, 2022
@dgrammatiko
Copy link
Contributor Author

dgrammatiko commented Apr 1, 2022

@bembelimen is there any interest for this one or should I close it?

@laoneo
Copy link
Member

laoneo commented Apr 1, 2022

I have tested this item ✅ successfully on 746b970


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36353.

@laoneo
Copy link
Member

laoneo commented Apr 1, 2022

image

@laoneo
Copy link
Member

laoneo commented Apr 1, 2022

Tested with reordering a module and the last screenshot is the request with all variables.

@laoneo
Copy link
Member

laoneo commented Apr 1, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36353.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 1, 2022
@dgrammatiko
Copy link
Contributor Author

@bembelimen any decision here?

@roland-d roland-d merged commit 67acb22 into joomla:4.1-dev Apr 22, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 22, 2022
@roland-d
Copy link
Contributor

Thanks everybody.

@roland-d roland-d added this to the Joomla 4.1.3 milestone Apr 22, 2022
@dgrammatiko dgrammatiko deleted the 4.1-dev-order-formdata branch April 22, 2022 19:20
@dgrammatiko
Copy link
Contributor Author

Nice, that was my last pending PR, so good news for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants