Skip to content

Conversation

@tecpromotion
Copy link
Contributor

Summary of Changes

During the translation into German and testing, an error occurred in the display of the duration time.

This PR shows the correct output.

Testing Instructions

create a new taks an click Run Test.

Actual result BEFORE applying this Pull Request

2021-12-12_15-46-24

Expected result AFTER applying this Pull Request

2021-12-12_15-46-53

Documentation Changes Required

.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Dec 12, 2021
@brianteeman
Copy link
Contributor

ouch - I made that change and none of the testers spotted it

@tecpromotion
Copy link
Contributor Author

ouch - I made that change and none of the testers spotted it

yes, unfortunately i didn't test that enough with my team when beta1 was released. but we should test it thoroughly again before the stable release.

@Quy
Copy link
Contributor

Quy commented Dec 13, 2021

I have tested this item ✅ successfully on 8474a84


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.

@Quy Quy removed the Language Change This is for Translators label Dec 13, 2021
@Quy
Copy link
Contributor

Quy commented Dec 13, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 13, 2021
@khu5h1
Copy link
Contributor

khu5h1 commented Dec 14, 2021

I have tested this item ✅ successfully on 8474a84


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.

@richard67 richard67 added this to the Joomla 4.1 milestone Dec 17, 2021
@Shubhamverma2796
Copy link
Contributor

I have tested this item ✅ successfully on 8474a84


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.

@wojsmol
Copy link
Contributor

wojsmol commented Dec 22, 2021

@tecpromotion Please use %f instead.

@Quy Quy removed the RTC This Pull Request is Ready To Commit label Dec 22, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.1 milestone Dec 22, 2021
@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Dec 24, 2021
@richard67
Copy link
Member

@tecpromotion Could you have a look on the review suggestions and check if "%f" works, and if so, change to that? I'd like to come forward here, but I'm a bit reluctant to set RTC as long as there are open review discussions.

@tecpromotion
Copy link
Contributor Author

@tecpromotion Could you have a look on the review suggestions and check if "%f" works, and if so, change to that? I'd like to come forward here, but I'm a bit reluctant to set RTC as long as there are open review discussions.

I can check this later.

@tecpromotion
Copy link
Contributor Author

tecpromotion commented Dec 30, 2021

@tecpromotion Please use %f instead.

@wojsmol Sorry but '%f' does not work here.

modal.querySelector('.modal-body > div').innerHTML += `<div>${Joomla.Text._('COM_SCHEDULER_TEST_RUN_DURATION').replace('%s', output.data.duration.toFixed(2))}</div>`;

Here a '%s' is searched for and replaced.

Change both to %f does not work.

@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Dec 30, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 30, 2021
@richard67 richard67 added this to the Joomla 4.1 milestone Dec 30, 2021
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Dec 30, 2021
@bembelimen bembelimen merged commit 0bb543b into joomla:4.1-dev Dec 31, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 31, 2021
@bembelimen
Copy link
Contributor

Thx

@alikon
Copy link
Contributor

alikon commented Dec 31, 2021

merged ? !!!!
why ? 🤕
evidently feedback from some are not welcomed or better simply ignored

@richard67
Copy link
Member

@alikon Why ignored? @tecpromotion has checked with "%s" as requested and has reported back why we can't do that with the js as it is now.

@alikon
Copy link
Contributor

alikon commented Dec 31, 2021

this doesn't prove it's correct

@tecpromotion
Copy link
Contributor Author

this doesn't prove it's correct

You're absolutely right, but that doesn't solve the problem.
A developer has to sit down and fix it everywhere.
Now there is an output and no more error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants