-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.1] Unification of the language com_scheduler, part 3 #36297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Unification of the language com_scheduler, part 3 #36297
Conversation
|
ouch - I made that change and none of the testers spotted it |
yes, unfortunately i didn't test that enough with my team when beta1 was released. but we should test it thoroughly again before the stable release. |
|
I have tested this item ✅ successfully on 8474a84 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297. |
|
I have tested this item ✅ successfully on 8474a84 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297. |
|
I have tested this item ✅ successfully on 8474a84 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297. |
|
@tecpromotion Please use |
|
@tecpromotion Could you have a look on the review suggestions and check if "%f" works, and if so, change to that? I'd like to come forward here, but I'm a bit reluctant to set RTC as long as there are open review discussions. |
I can check this later. |
@wojsmol Sorry but '%f' does not work here.
Here a '%s' is searched for and replaced. Change both to %f does not work. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297. |
|
Thx |
|
merged ? !!!! |
|
@alikon Why ignored? @tecpromotion has checked with "%s" as requested and has reported back why we can't do that with the js as it is now. |
|
this doesn't prove it's correct |
You're absolutely right, but that doesn't solve the problem. |
joomla/joomla-cms#30522 + joomla/joomla-cms#32223 + joomla/joomla-cms#31675 + joomla/joomla-cms#35378 + joomla/joomla-cms#35612 + joomla/joomla-cms#35715 + joomla/joomla-cms#35610 + joomla/joomla-cms#35607 + joomla/joomla-cms#35788 + joomla/joomla-cms#35647 + joomla/joomla-cms#35143 + joomla/joomla-cms#36135 + joomla/joomla-cms#35998 + joomla/joomla-cms#36173 + joomla/joomla-cms#36212 + joomla/joomla-cms#36208 + joomla/joomla-cms#36206 + joomla/joomla-cms#36205 + joomla/joomla-cms#36203 + joomla/joomla-cms#36192 + joomla/joomla-cms#36191 + joomla/joomla-cms#36228 + joomla/joomla-cms#36211 + joomla/joomla-cms#36271 + joomla/joomla-cms#36270 + joomla/joomla-cms#36245 + joomla/joomla-cms#36294 + joomla/joomla-cms#36244 + joomla/joomla-cms#36242 + joomla/joomla-cms#36296 + joomla/joomla-cms#36190 + joomla/joomla-cms#36474 + joomla/joomla-cms#36297 + joomla/joomla-cms#36480 + joomla/joomla-cms#36479 + joomla/joomla-cms#36551 + joomla/joomla-cms#36366 + joomla/joomla-cms#36589 + joomla/joomla-cms#36583 + joomla/joomla-cms#36328 + joomla/joomla-cms#36515 + joomla/joomla-cms#36555 + joomla/joomla-cms#36653 + joomla/joomla-cms#36660 + joomla/joomla-cms#36657 + joomla/joomla-cms#36637 + joomla/joomla-cms#35983 + joomla/joomla-cms#36704 + joomla/joomla-cms#36708 + joomla/joomla-cms#36700 +
Summary of Changes
During the translation into German and testing, an error occurred in the display of the duration time.
This PR shows the correct output.
Testing Instructions
create a new taks an click Run Test.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
.