-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Refactor the page cache plugin #36042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
laoneo
merged 26 commits into
joomla:4.2-dev
from
nikosdion:feature/cache-plugin-refactor
May 13, 2022
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7fcfd9c
Refactor the page cache plugin
e02d6de
Don't try to fix stupid
42946c0
Make the plugin class final
7c0ee86
Using low priority
6eda02a
Inject factories into the plugin
444fdb2
Refactor the page cache plugin
45c617b
Don't try to fix stupid
8576947
Make the plugin class final
e53aa91
Using low priority
b2a50ee
Inject factories into the plugin
4b6a2bf
Merge remote-tracking branch 'nikosdion/feature/cache-plugin-refactor…
nikosdion 86369ce
Merge remote-tracking branch 'joomla/4.2-dev' into feature/cache-plug…
nikosdion 1fcce43
Remove version attribute from the XML manifest
nikosdion 1b57bc6
Remove useless line
nikosdion 4217285
Make protected members private
nikosdion 5a6d570
Inject the profiler
nikosdion 52e20e3
Merge branch '4.2-dev' into feature/cache-plugin-refactor
laoneo 8504b4e
Merge branch '4.2-dev' into feature/cache-plugin-refactor
nikosdion dbc7acd
Fix docblock
nikosdion 8319325
Inject frontend router object
nikosdion 3db06ca
Merge branch '4.2-dev' into feature/cache-plugin-refactor
laoneo 47831bc
Update plugins/system/cache/services/provider.php
laoneo 2eec592
Update plugins/system/cache/services/provider.php
laoneo 89af2b8
Update plugins/system/cache/services/provider.php
laoneo 6b36537
Update plugins/system/cache/services/provider.php
laoneo da17dd2
Merge branch '4.2-dev' into feature/cache-plugin-refactor
laoneo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| <?php | ||
| /** | ||
| * @package Joomla.Plugin | ||
| * @subpackage System.cache | ||
| * | ||
| * @copyright (C) 2021 Open Source Matters, Inc. <https://www.joomla.org> | ||
laoneo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
|
|
||
| defined('_JEXEC') or die; | ||
|
|
||
| use Joomla\CMS\Extension\PluginInterface; | ||
| use Joomla\CMS\Plugin\PluginHelper; | ||
| use Joomla\DI\Container; | ||
| use Joomla\DI\ServiceProviderInterface; | ||
| use Joomla\Event\DispatcherInterface; | ||
| use Joomla\Plugin\System\Cache\Extension\Cache; | ||
|
|
||
| return new class implements ServiceProviderInterface { | ||
| /** | ||
| * Registers the service provider with a DI container. | ||
| * | ||
| * @param Container $container The DI container. | ||
| * | ||
| * @return void | ||
| * @since __DEPLOY_VERSION__ | ||
| */ | ||
| public function register(Container $container) | ||
| { | ||
| $container->set( | ||
| PluginInterface::class, | ||
| function (Container $container) | ||
| { | ||
| $plugin = PluginHelper::getPlugin('system', 'cache'); | ||
| $dispatcher = $container->get(DispatcherInterface::class); | ||
|
|
||
| return new Cache($dispatcher, (array) $plugin); | ||
| } | ||
| ); | ||
| } | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.