Merged
Conversation
This is a replacement to part of the merged PR joomla#30294 It does exactly the same thing but by using css logical properties we avoid the need to maintain both an LTR and an RTL version There is no visual change.
joomla-cms-bot
added
NPM Resource Changed
Contributor
|
I have tested this item ✅ successfully on 70a040f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 70a040f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031. |
Member
|
@Shubhamverma2796 @khu5h1 You have tested with an RTL language, too? |
Member
|
I have tested this item ✅ successfully on 70a040f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031. |
Member
|
@infograf768 I'm a bit confused about your positive test. In the other PR #36040 you pointed out that inset-inline-end is not supported by Safari 14 and lower, and this PR uses the same logical property inset-inline-end. |
Contributor
|
@richard67 I have tested with an RTL language on Chrome and Firefox browsers. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031. |
Member
|
Grr. RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031. |
Member
|
Setting RLDQ label so release leads can decide about usage of inset-inline regarding our browser support policy. |
Contributor
|
I have tested this item ✅ successfully on 70a040f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031. |
Contributor
|
Thanks! |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement to part of the merged PR #30294
It does exactly the same thing but by using css logical properties we avoid the need to maintain both an LTR and an RTL version
There is no visual change.
