Skip to content

[4.0] Fancy selectbox fix#36026

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
brianteeman:atem-logical-choices
Nov 28, 2021
Merged

[4.0] Fancy selectbox fix#36026
wilsonge merged 2 commits intojoomla:4.0-devfrom
brianteeman:atem-logical-choices

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Nov 13, 2021

This is a replacement to the merged PR #30739 for atum and to identical code in cassiopeia

It does exactly the same thing but by using css logical properties we avoid the need to maintain both an LTR and an RTL version

There is no visual change.

image

This is a replacement to the merged PR joomla#30739

It does exactly the same thing but by using css logical properties we avoid the need to maintain both an LTR and an RTL version

There is no visual change.
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Nov 13, 2021
@Quy
Copy link
Contributor

Quy commented Nov 14, 2021

I have tested this item ✅ successfully on b282797


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36026.

1 similar comment
@Shubhamverma2796
Copy link
Contributor

I have tested this item ✅ successfully on b282797


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36026.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36026.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 15, 2021
@khu5h1
Copy link
Contributor

khu5h1 commented Nov 15, 2021

I have tested this item ✅ successfully on b282797


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36026.

@richard67 richard67 added the RMDQ ReleaseManagerDecisionQueue label Nov 18, 2021
@richard67
Copy link
Member

Setting RLDQ label so release leads can decide about usage of inset-inline regarding our browser support policy.

@pritam825
Copy link
Contributor

I have tested this item ✅ successfully on b282797


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36026.

@wilsonge wilsonge merged commit fbe92a8 into joomla:4.0-dev Nov 28, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 28, 2021
@wilsonge wilsonge added this to the Joomla 4.0.5 milestone Nov 28, 2021
@wilsonge
Copy link
Contributor

Thanks!

@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the atem-logical-choices branch November 28, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester RMDQ ReleaseManagerDecisionQueue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants