Skip to content

ExtensionAdapter should expect a client_id as either integer or string #35822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikosdion wants to merge 1 commit into from
Closed

ExtensionAdapter should expect a client_id as either integer or string #35822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion libraries/src/Updater/Adapter/ExtensionAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,18 @@ public function findUpdate($options)
{
if (isset($this->latest->client) && \strlen($this->latest->client))
{
$this->latest->client_id = ApplicationHelper::getClientInfo($this->latest->client, true)->id;
/**
* The client_id in the update XML manifest can be either an integer (backwards
* compatible with Joomla 1.6–3.10) or a string. Backwards compatibility with the
* integer key is only provided in the 4.x release as a means to facilitate
* migration of legacy extensions to Joomla 4. Joomla 5 will remove the b/c code and
* require client_id to be a string key. The string key is one of 'site' or
* 'administrator'.
Copy link
Contributor

@brianteeman brianteeman Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to be pedantic but couldnt the client key also be api?

Copy link
Contributor Author

@nikosdion nikosdion Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no and I did check 😉 We do not have api–specific extensions. In fact, the only way to extend the API is by adding an <api> target in the XML manifest of a component. Components are installed in the administrator application i.e. their client_id is 1.

Copy link
Contributor

@brianteeman brianteeman Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - cool

*
* @deprecated 5.0
*/
$this->latest->client_id = is_numeric($this->latest->client) ? $this->latest->client
: ApplicationHelper::getClientInfo($this->latest->client, true)->id;

unset($this->latest->client);
}
Expand Down