Update link.php

[kapetanov]

the pagnation in has an misuse of the aria-label. i fixed it with two span tags.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

[brianteeman]

Sorry I dont understand this change

[kapetanov]

the aria-label does not work in span tags. that's why i put the value of the aria-label in a hidden span tag. assistive technology will be able to read this span tag. the original span tag is shown on normal displays and its hidden (aria-hidden="true") for assistive technology. thats why i use two span tags. one for assistive technology and one for displays.

[brianteeman]

the aria-label does not work in span tags.

it does if its an interactive element - I agree that its not interactive here.

that's why i put the value of the aria-label in a hidden span tag

this is what I dont understand - it is still a non interactive span so it will still be ignored

[brianteeman]

Before

After

[kapetanov]

you need the value of the aria label because otherwise only the number of the page are readable for assistive technologies. that would be too little for people with visual impairment. for example, instead of '1' for assistive technologies, 'page 1' should be readable.

[brianteeman]

only the number of the page are readable for assistive technologies. that would be too little for people with visual impairment.

I agree

The problem is that I do not see how your change will do that. The screenshots show that its not exposed in the accessibility tree

[kapetanov]

ok, i see what u mean

[kapetanov]

i think its the hidden css of bootstrap

[kapetanov]

ok, the current page must also be an link (a tag). not a span tag. then the aria-label will work (active element). tomorrow i made a new workaround.

[brianteeman]

Not completely tested but this should work

<a aria-current="true" aria-label="<?php echo $aria; ?>" href="#" class="page-link"><?php echo $display; ?></a>

[richard67]

@kapetanov It seems this PR is made to solve your issue #35758 . if that is right, you should have mentioned that issue at the top of your PR description, i.e. „Pull request for issue #35758 “. Please add that, and please close your issue with reference to the pull request here. Thanks in advance.

[kapetanov]

@brianteeman yes, it works. i have tested it.

[patvb2003]

I have tested this item ✅ successfully on 19a3ddd

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35771.}

[kiki-G]

I have tested this item ✅ successfully on 19a3ddd

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35771.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35771.}

[chmst]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35771.}

[laoneo]

Thanks!