[4.4] Invalid timings in debug plugin#35655
Merged
MacJoom merged 45 commits intojoomla:4.4-devfrom Sep 11, 2023
Merged
Conversation
brianteeman
reviewed
Sep 24, 2021
brianteeman
reviewed
Sep 24, 2021
brianteeman
reviewed
Sep 24, 2021
PhilETaylor
reviewed
Sep 24, 2021
PhilETaylor
reviewed
Sep 24, 2021
PhilETaylor
reviewed
Sep 24, 2021
PhilETaylor
reviewed
Sep 24, 2021
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
PhilETaylor
reviewed
Sep 24, 2021
PhilETaylor
reviewed
Sep 24, 2021
PhilETaylor
reviewed
Sep 24, 2021
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
PhilETaylor
reviewed
Sep 24, 2021
PhilETaylor
reviewed
Sep 24, 2021
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Member
|
Can you fix the conflicts here? |
obuisard
changed the title
Contributor
Author
|
@laoneo Please restart drone, smth is wrong with the tests and I can't find any relationship with the code itself. |
Contributor
Author
|
Sorry, still weird issue with databases in drone |
4 tasks
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Sep 22, 2023
Enable debug and then trigger a 404 on the frontend Instead of the regular 404 page we get a 404 and a 500 This is caused by the line commented out in this PR. That line was added by joomla#35655 Sorry I can't contribute a _real_ solution as I don't understand the code. I was just able to locate the source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The time and memory displayed in debug bar (right position) incorrectly includes the usage of debug plugin itself: it's always much bigger than the sum of all timings in Profile tab.
We can't measure 100% correctly but at least should get closer: the most recent profile mark should have right border as closer to right as possible.
See that
afterRenderprofile mark is not close the the right, hence we have incorrectly logged total time: it includes the time spent in debug plugin itself and we don't see the real state of page generation.Joomla\Event\SubscriberInterfaceonAfterRespondevent is not counted.afterRespondprofiler mark.onAfterDisconnectevent by debug plugin is included in request time.PlgSystemDebug::$totalQueriesvariablePlgSystemDebug::sqlShowProfilesto local variable because it's the only usage.Testing Instructions
Apply patch, see more accurate timings in debug. Profile tab marks are now more proportionally to the 100% width.
Actual result BEFORE applying this Pull Request
See issues in Changes above.
Expected result AFTER applying this Pull Request
See issues in Changes above.
Documentation Changes Required
No.