[#33688] JApplicationCms::getRouter is a static method

[wilsonge]

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33688&start=0

We need to grab the JRouterSite/JRouterAdministrator object in various places in Joomla. And currently the function is a static function. But we're not calling it statically - and with the PHPUnit upgrade travis has just done that's suddenly become important as we can't mock the static methods. So we now must call this correctly for the unit tests to function (see #3550)

Testing

• Check that routing in frontend & backend still work (SEF URLs on & off)
• Check the com_finder frontend search view still works and generates the correct URLS
• Check internal links (that would use JRoute) work as expected. i.e. going from category view to single article view.
• Check login module redirection url works
• Check language filter plugin still works

[zero-24]

1. routing BE and FE works good here (SEF on and off)
2. com_finder works here as bevor (SEF on and off)
3. internal links works ok. (category blog --> single article, category list --> single article) (SEF on and off)
4. login and logout redirection ok here. (SEF on and off)

@wilsonge how can i check the language filter plugin?

[wilsonge]

You'll need to install and second language and enable the plugin and check the URLs in both languages work as it did pre-patch - because that adds it's own build + parse rules to the routing

[infograf768]

OK, here, including in multilang

[infograf768]

@maintainers
This PR is just for testing. The PR #3550 contains this one.

[Bakual]

This PR is just for testing. The PR #3550 contains this one.

@infograf768 Merged this one so the unit tests are in a separate commit. Had a conversation with @wilsonge over it 😃