Combine update statements for package_id of search extensions #35176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
System tests are broken due to merged PR #35168 in the 40-dev branch. |
Member
|
Working for version 5.6.40-84.0 |
Contributor
|
Works ok on 10.4.13-MariaDB |
richard67
changed the title
zero-24
reviewed
Aug 17, 2021
administrator/components/com_admin/sql/updates/mysql/4.0.0-2021-08-17.sql
Outdated
Show resolved
Hide resolved
zero-24
reviewed
Aug 17, 2021
administrator/components/com_admin/sql/updates/postgresql/4.0.0-2021-08-17.sql
Outdated
Show resolved
Hide resolved
…1-08-17.sql Co-authored-by: Tobias Zulauf <[email protected]>
…0-2021-08-17.sql Co-authored-by: Tobias Zulauf <[email protected]>
Member
|
Thanks @richard67 and @zero-24 |
Contributor
|
Thanks @richard67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fix the SQL update statement from PR #35164 for certain older MySQL or MariaDB versions.
Use (almost) the same changes also for PostgreSQL because it's better SQL.
CROSS JOIN is supported on MySQL 5.6. so it is ok for Joomla 4.
On PostgreSQL it is supported too, but not in UPDATE statements, it seems, therefore the slightly different syntax for PostgreSQL.
Testing Instructions
Update from 3.10 to 4.0 using a new package which includes the merged PR Handle com_search migration to a core supported extension #35164 .
You can build a package with following command:
php ./build/build.php --remote=HEAD --exclude-gzip --exclude-bzip2Result: See section "Actual result BEFORE applying this Pull Request" below.
Do the same again but use the update package built by drone for this PR.
Result: See section "Expected result AFTER applying this Pull Request" below.
Actual result BEFORE applying this Pull Request
On certain older MySQL (5.7 in my case) or MariaDB versions:
On newer versions of MySQL or MariaDB and on PostgreSQL there is no such error.
Expected result AFTER applying this Pull Request
No such SQL error on any supported database version.
Documentation Changes Required
None.