-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.0] fix translator note in joomla.ini / plg_editors_tinymce.ini #35065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@brianteeman I hope this is correct, I noticed it during the translation. |
brianteeman
reviewed
Aug 7, 2021
Contributor
|
My bad. Need more coffee - this is all good |
Contributor
|
I have tested this item ✅ successfully on 515c6b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35065. |
Contributor
Author
coffee is a good idea. me too. |
Member
|
I have tested this item ✅ successfully on 515c6b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35065. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35065. |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
the comment for the translators was inserted after the string
Testing Instructions
not required
Actual result BEFORE applying this Pull Request
e.g.
Expected result AFTER applying this Pull Request
JFIELD_MEDIA_DOWNLOAD_FILE="Download {file}" ; Do not translate the text between the {}Documentation Changes Required
.