Skip to content

Conversation

@tecpromotion
Copy link
Contributor

@tecpromotion tecpromotion commented Aug 7, 2021

Summary of Changes

the comment for the translators was inserted after the string

Testing Instructions

not required

Actual result BEFORE applying this Pull Request

e.g.

; Do not translate the text between the {}
JFIELD_MEDIA_DOWNLOAD_FILE="Download {file}"

Expected result AFTER applying this Pull Request

JFIELD_MEDIA_DOWNLOAD_FILE="Download {file}" ; Do not translate the text between the {}

Documentation Changes Required

.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Aug 7, 2021
@tecpromotion tecpromotion changed the title [4.0] fix translator note in joomla.ini [4.0] fix translator note in joomla.ini / plg_editors_tinymce.ini Aug 7, 2021
@tecpromotion
Copy link
Contributor Author

@brianteeman I hope this is correct, I noticed it during the translation.

@brianteeman
Copy link
Contributor

My bad. Need more coffee - this is all good

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 515c6b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35065.

@tecpromotion
Copy link
Contributor Author

My bad. Need more coffee - this is all good

coffee is a good idea. me too.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 515c6b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35065.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35065.

@richard67 richard67 removed Language Change This is for Translators PR-4.0-dev labels Aug 7, 2021
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2021
@richard67 richard67 added Language Change This is for Translators PR-4.0-dev labels Aug 7, 2021
@wilsonge wilsonge added this to the Joomla 4.0.1 milestone Aug 7, 2021
@wilsonge wilsonge merged commit 09ec026 into joomla:4.0-dev Aug 20, 2021
@wilsonge
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants