Skip to content

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Jul 14, 2021

Pull Request for Issue #34634

Summary of Changes

Add fallback for the new media setting and fix some phpcs

Testing Instructions

Install 3.10-alpha9
Upgrade to the latest 4.0
Notice that you can not upload images in the media manager
Install a new 3.10-alpha9
Update using this update server (https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/34778/downloads/45806/pr_list.xml)
Notice that the upload works

Actual result BEFORE applying this Pull Request

Media Manager Upload works

Expected result AFTER applying this Pull Request

Media Manager upload does not work when the option is not set yet.

Documentation Changes Required

none

@zero-24 zero-24 added this to the Joomla 4.0 milestone Jul 14, 2021
@particthistle
Copy link
Member

I have tested this item ✅ successfully on 733728b

Before: 4.0.0-rc5-dev (13/7/2021) was unable to upload images.

After: 4.0.0-rc5-dev+pr.34778 - able to upload images to media manager.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34778.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 733728b

Easier test:

  1. Update a current 3.10-dev or latest 3.10 nightly or 3.10-alpha9 to the latest 4.0 nightly build.
  2. Try to upload a png file in media manager => fails.
  3. Update now to the custom update URL built by Drone for this PR.
  4. Try to upload a png file in media manager => works.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34778.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jul 14, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34778.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 14, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Jul 14, 2021
@Quy Quy merged commit 6ae84ff into joomla:4.0-dev Jul 14, 2021
@Quy
Copy link
Contributor

Quy commented Jul 14, 2021

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 14, 2021
@zero-24 zero-24 deleted the media_fallback_cs branch July 14, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants