Skip to content

[4.0] Figure out the image size for external adapters#34177

Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom
dgrammatiko:—image-select-dropbox—4.0-dev
May 26, 2021

Hidden character warning

The head ref may contain hidden characters: "\u2014image-select-dropbox\u20144.0-dev"
Merged

[4.0] Figure out the image size for external adapters#34177
rdeutz merged 2 commits intojoomla:4.0-devfrom
dgrammatiko:—image-select-dropbox—4.0-dev

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request is supplamentary to #33724

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@dgrammatiko dgrammatiko force-pushed the —image-select-dropbox—4.0-dev branch from 79c4d80 to 5252057 Compare May 24, 2021 15:48
@richard67
Copy link
Member

I have tested this item ✅ successfully on 5252057

I've tested with success as follows:

  1. Applied the patch from PR [4.0] Support External Adapters For Media Form Field #33724 and installed the dropbox plugin as described there in testing instructions.
  2. Removed the guzzlehttp folder from the plugin's vendor folder as described here, so that the one shipped with the CMS is used, to work around the issue linked in that comment, too: [4.0] Support External Adapters For Media Form Field #33724 (comment) .
  3. Inserted an image into an article, using an image from the Dropbox.
    Result: See [4.0] Support External Adapters For Media Form Field #33724 (comment) .
  4. Applied the patch of this PR.
  5. Repeated step 3 a few times with different images:
    Result: Image is visible, and the tag has the height and width attributes equal to height and width of the image.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34177.

@richard67
Copy link
Member

@chmst Could you test this PR as desribed in my test result above?

It's the same test you already have done for @joomdonation 's PR with the external Dropbox adapter.

First check if it has your issue, then apply the patch of this PR here, too, run npm ci and check again.

For me it worked.

@chmst
Copy link
Contributor

chmst commented May 26, 2021

I have tested this item ✅ successfully on 5252057


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34177.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34177.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 26, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 26, 2021
@dgrammatiko
Copy link
Contributor Author

Please DO NOT merge this BEFORE #33724

@richard67
Copy link
Member

@dgrammatiko The other PR has been merged now. Could you solve here the conflict resulting from that?

@richard67
Copy link
Member

Previous tests and RTC are still valid since the one commit after the tests was a clean branch update. In addition I have repeated my test with the same result as before, success.

@rdeutz rdeutz merged commit 6903269 into joomla:4.0-dev May 26, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 26, 2021
@dgrammatiko dgrammatiko deleted the —image-select-dropbox—4.0-dev branch May 26, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants