[4.0] refactor the media adapters

administrator/components/com_media/resources/scripts/store/state.es6.js

@@ -6,12 +6,25 @@ if (options.providers === undefined || options.providers.length === 0) {
   throw new TypeError('Media providers are not defined.');
 }
 
+/**
+ * Get the drives
+ *
+ * @param  {Array}  adapterNames
+ * @param  {String} provider
+ *
+ * @return {Array}
+ */
+const getDrives = (adapterNames, provider) => {
+  const drives = [];
+  adapterNames.map((name) => drives.push({ root: `${provider}-${name}:/`, displayName: name }));
+
+  return drives;
+};
+
 // Load disks from options
 const loadedDisks = options.providers.map((disk) => ({
   displayName: disk.displayName,
-  drives: disk.adapterNames.map(
-    (account, index) => ({ root: `${disk.name}-${index}:/`, displayName: account }),
-  ),
+  drives: getDrives(disk.adapterNames, disk.name),
 }));
 
 if (loadedDisks[0].drives[0] === undefined || loadedDisks[0].drives.length === 0) {

build/media_source/system/js/fields/joomla-image-select.w-c.es6.js

@@ -12,7 +12,7 @@
    *   extension: "png"
    *   fileType: "image/png"
    *   height: 44
-   *   path: "local-0:/powered_by.png"
+   *   path: "local-images:/powered_by.png"
    *   thumb: undefined
    *   width: 294
    * }

layouts/joomla/form/field/media.php

@@ -104,7 +104,7 @@
 $url    = ($readonly ? ''
 	: ($link ?: 'index.php?option=com_media&view=media&tmpl=component&asset='
 		. $asset . '&author=' . $authorId)
-	. '&fieldid={field-media-id}&path=local-0:/' . $folder);
+	. '&fieldid={field-media-id}&path=local-images:/' . $folder);
 
 // Correctly route the url to ensure it's correctly using sef modes and subfolders
 $url = Route::_($url);

plugins/editors/tinymce/tinymce.php

@@ -543,7 +543,7 @@ public function onDisplay(
 			$scriptOptions['uploadUri']          = $uploadUrl;
 
 			// @TODO have a way to select the adapter, similar to $levelParams->get('path', '');
-			$scriptOptions['comMediaAdapter']    = 'local-0:';
+			$scriptOptions['comMediaAdapter']    = 'local-images:';
 		}
 
 		// Convert pt to px in dropdown

plugins/filesystem/local/local.php

@@ -94,7 +94,12 @@ public function getAdapters()
 			{
 				$directoryPath = JPATH_ROOT . '/' . $directoryEntity->directory;
 				$directoryPath = rtrim($directoryPath) . '/';
-				$adapters[]    = new \Joomla\Plugin\Filesystem\Local\Adapter\LocalAdapter($directoryPath, $directoryEntity->directory);
+
+				$adapter = new \Joomla\Plugin\Filesystem\Local\Adapter\LocalAdapter(
+					$directoryPath, $directoryEntity->directory
+				);
+
+				$adapters[$adapter->getAdapterName()] = $adapter;
 			}
 		}
 

plugins/filesystem/local/local.xml

@@ -29,7 +29,7 @@
 					label="PLG_FILESYSTEM_LOCAL_DIRECTORIES_LABEL"
 					multiple="true"
 					layout="joomla.form.field.subform.repeatable-table"
-					buttons="add,remove"
+					buttons="add,remove,move"
 					default='[{"directory":"images"}]'
 				>
 					<form>

tests/Codeception/_support/Page/Acceptance/Administrator/MediaListPage.php

@@ -24,7 +24,7 @@ class MediaListPage extends AdminListPage
 	 * @var    string
 	 * @since  4.0.0
 	 */
-	public static $url = "administrator/index.php?option=com_media&path=local-0:/";
+	public static $url = "administrator/index.php?option=com_media&path=local-images:/";
 
 	/**
 	 * Page title of the media manager listing page.

tests/Codeception/acceptance/administrator/components/com_media/MediaListCest.php

@@ -741,7 +741,7 @@ public function openImageEditorUsingActionMenu(Media $I)
 		$I->amOnPage(MediaListPage::$url);
 		$I->waitForMediaLoaded();
 		$I->clickOnActionInMenuOf('powered_by.png', MediaListPage::$editAction);
-		$I->seeInCurrentUrl(MediaFilePage::$url . '&path=local-0:/powered_by.png');
+		$I->seeInCurrentUrl(MediaFilePage::$url . '&path=local-images:/powered_by.png');
 	}
 
 	/**
@@ -894,7 +894,7 @@ public function synchronizeAppStateWithSessionStorage(Media $I)
 		$I->amOnPage(MediaListPage::$url);
 		$I->waitForMediaLoaded();
 		$json = $I->executeJS('return sessionStorage.getItem("' . MediaListPage::$storageKey . '")');
-		$I->assertContains('"selectedDirectory":"local-0:/"', $json);
+		$I->assertContains('"selectedDirectory":"local-images:/"', $json);
 		$I->assertContains('"showInfoBar":false', $json);
 		$I->assertContains('"listView":"grid"', $json);
 		$I->assertContains('"gridSize":"md"', $json);
@@ -904,7 +904,7 @@ public function synchronizeAppStateWithSessionStorage(Media $I)
 		$I->click(MediaListPage::$increaseThumbnailSizeButton);
 		$I->click(MediaListPage::$toggleListViewButton);
 		$json = $I->executeJS('return sessionStorage.getItem("' . MediaListPage::$storageKey . '")');
-		$I->assertContains('"selectedDirectory":"local-0:/banners"', $json);
+		$I->assertContains('"selectedDirectory":"local-images:/banners"', $json);
 		$I->assertContains('"showInfoBar":true', $json);
 		$I->assertContains('"listView":"table"', $json);
 		$I->assertContains('"gridSize":"lg"', $json);