Skip to content

[4.0] Improve the cli command discover#33749

Merged
rdeutz merged 25 commits intojoomla:4.0-devfrom
astridx:cli
May 20, 2021
Merged

[4.0] Improve the cli command discover#33749
rdeutz merged 25 commits intojoomla:4.0-devfrom
astridx:cli

Conversation

@ghost
Copy link

@ghost ghost commented May 10, 2021

Pull Request for Issue #32967 .

Summary of Changes

I have corrected the misleading duplicate consoles outputs mentioned in #32967 and I have added a task to install and a task to list the detected extensions.

Testing Instructions

Run

php cli/joomla.php extension:discover:list

php cli/joomla.php extension:discover:install

and

php cli/joomla.php extension:discover

The following is an example:

php cli/joomla.php extension:discover:list

 ! [NOTE] Cannot find discovered extensions. Perhaps you need to run extension:discover first?                          

php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover:install

 ! [NOTE] There are no discovered extensions for install. Perhaps you need to run extension:discover first?             

php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover

 ! [NOTE] 4 extensions have been discovered successfully.                                                               

php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover:list

Discovered extensions.
======================

 ------------------------ -------------- --------- ---------- -------- 
  Name                     Extension ID   Version   Type       Active  
 ------------------------ -------------- --------- ---------- -------- 
  en-GB                    306            4.0.0     language   No      
  en-GB                    307            4.0.0     language   No      
  en-GB                    308            4.0.0     language   No      
  plg_sampledata_testing   309            4.0.0     plugin     No      
 ------------------------ -------------- --------- ---------- -------- 

php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover:install --eid 306

                                                                                                                        
 [OK] Extension with ID 306 installed successfully.                                                                     
                                                                                                                        

php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover:install 

 ! [NOTE] 3 discovered extensions have been installed.     

Actual result BEFORE applying this Pull Request

See #31524

Documentation Changes Required

Yes: https://docs.joomla.org/J4.x:CLI_Update

@PhilETaylor

This comment was marked as abuse.

@ceford
Copy link
Contributor

ceford commented May 11, 2021

I have tested this item ✅ successfully on be63829

Commands worked as described - discovered and then installed one extension.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33749.

agi-code and others added 3 commits May 11, 2021 19:27
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
agi-code and others added 3 commits May 11, 2021 19:28
…est.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
@ghost
Copy link
Author

ghost commented May 11, 2021

@PhilETaylor I committed all your suggestions. Please have look, if everything is fine.

@PhilETaylor

This comment was marked as abuse.

@alikon
Copy link
Contributor

alikon commented May 11, 2021

@PhilETaylor

This comment was marked as abuse.

@alikon
Copy link
Contributor

alikon commented May 11, 2021

funny when we have a pr with unit/system code too 😄

@PhilETaylor

This comment was marked as abuse.

@alikon
Copy link
Contributor

alikon commented May 11, 2021

that's another issue
let me be happy to see a pr with system tests ..... whatever

plus a cli pr 👍

@PhilETaylor

This comment was marked as abuse.

@alikon
Copy link
Contributor

alikon commented May 12, 2021

I have tested this item ✅ successfully on 646a889


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33749.

@alikon
Copy link
Contributor

alikon commented May 18, 2021

@PhilETaylor can you please test this 1

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

richard67 commented May 18, 2021

@PhilETaylor Well there were commits after your test ... but I've just checked, it was just texts .. so I restore your result in the issue tracker.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33749.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 18, 2021
@richard67
Copy link
Member

Just texts I meant.

@richard67 richard67 added this to the Joomla 4.0 milestone May 18, 2021
@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

yes it was just tests and the unit tests now pass - that is good enough for me :)

@PhilETaylor Was a typo, not "tests", "texts" I meant. But it's ok.

@rdeutz rdeutz merged commit 4c6d9e8 into joomla:4.0-dev May 20, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 20, 2021
@astridx astridx deleted the cli branch January 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants