Skip to content

Comments

[4.0] Remove Migration Script#33428

Merged
Quy merged 3 commits intojoomla:4.0-devfrom
himanshu007-creator:himanshu007-creator-patch-1
May 7, 2021
Merged

[4.0] Remove Migration Script#33428
Quy merged 3 commits intojoomla:4.0-devfrom
himanshu007-creator:himanshu007-creator-patch-1

Conversation

@himanshu007-creator
Copy link
Contributor

@himanshu007-creator himanshu007-creator commented Apr 30, 2021

Pull Request for Issue #33379

Summary of Changes

Remove migration script for blog layout as now the function is no longer needed.

Testing Instructions

Install J3.10 and make some blogs with entries in num_columns. Update to J4.0
in J4.0, blog must have same same columns as there were in J3.10

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

none

@chmst
Copy link
Contributor

chmst commented Apr 30, 2021

@Harmageddon could you please have a look here? As we now have a param num_columns, the script is no longer needed.

@richard67
Copy link
Member

@himanshu007-creator Please change the title of this PR to something more meaningful about what the changes are good for.

@himanshu007-creator himanshu007-creator changed the title Update script.php [4.0] Remove Migration Script Apr 30, 2021
@joomdonation
Copy link
Contributor

Please remove some un-used use statements at the top of file:

use Joomla\CMS\Component\ComponentHelper;
use Joomla\CMS\Uri\Uri;
use Joomla\Component\Config\Administrator\Model\ComponentModel;

@joomdonation
Copy link
Contributor

@chmst In the original PR, some parameters were added as global class classes https://github.com/joomla/joomla-cms/pull/31570/files#diff-250b59d27f418e931b052803c0a6089439df3f1ada6db18096ec9f9e5edb095cR717-R731 .Do we need to keep these parameters or it should be reverted?

@Harmageddon
Copy link
Contributor

I don't have time today, but am going to have a look at this tomorrow. On a first glance: Looks good to me, thanks for taking care of this one!

@Harmageddon
Copy link
Contributor

I have tested this item ✅ successfully on 182ceb1

Tested upgrade from 3.9.26 (with column settings) and from 4.0-beta8 (with CSS classes). Nothing seems to break. PR does a clean removal of the upgrade functionality in #31570.

@joomdonation I'd keep those global parameters, as there may be use cases for setting CSS classes globally, and I don't see any disadvantages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428.

@richard67
Copy link
Member

richard67 commented May 2, 2021

Tested upgrade from 3.9.26 (with column settings) ...

@Harmageddon Did you do that directly from 3.9.26 to 4 and not with an intermediate 3.10? That might work when using "Upload & Update" but is not officially supported. It's ok for the test here, but I thought I should spread the information that it's not the official way.

(Sorry I've first mentioned the wrong person here, so @himanshu007-creator please ignore the notification.)

@Harmageddon
Copy link
Contributor

@Harmageddon Did you do that directly from 3.9.26 to 4 and not with an intermediate 3.10? That might work when using "Upload & Update" but is not officially supported. It's ok for the test here, but I thought I should spread the information that it's not the official way.

Ah yes, you're perfectly right there. I couldn't find my old backup I used for upgrade tests, that was probably on 3.10, and just picked a new download package. Sorry for that, still it worked! :-D

@ChristineWk
Copy link

Had already successfully used this procedure J 3.10 to J 4.0 a few times ... and at that time in the course of #31570 etc.
As described here: https://www.joomla.org/announcements/release-news/5833-joomla- 4-0-0-beta7-and-joomla-3-10-alpha5.html
Unfortunately it doesn't work at the moment. Success was: Error 500 etc.

Backup today of my J 3.10 imported again.
The current status is: Version of the database schema (in #__schemas): 3.10.0-2020-08-10
Update version (in #__extensions): 3.10.0-alpha6-dev
Sorry about that.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 182ceb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 7, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 7, 2021
@Quy Quy merged commit 9882099 into joomla:4.0-dev May 7, 2021
@Quy
Copy link
Contributor

Quy commented May 7, 2021

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants