[4.0] Remove Migration Script#33428
[4.0] Remove Migration Script#33428Quy merged 3 commits intojoomla:4.0-devfrom himanshu007-creator:himanshu007-creator-patch-1
Conversation
|
@Harmageddon could you please have a look here? As we now have a param num_columns, the script is no longer needed. |
|
@himanshu007-creator Please change the title of this PR to something more meaningful about what the changes are good for. |
|
Please remove some un-used use statements at the top of file: use Joomla\CMS\Component\ComponentHelper;
use Joomla\CMS\Uri\Uri;
use Joomla\Component\Config\Administrator\Model\ComponentModel; |
|
@chmst In the original PR, some parameters were added as global class classes https://github.com/joomla/joomla-cms/pull/31570/files#diff-250b59d27f418e931b052803c0a6089439df3f1ada6db18096ec9f9e5edb095cR717-R731 .Do we need to keep these parameters or it should be reverted? |
|
I don't have time today, but am going to have a look at this tomorrow. On a first glance: Looks good to me, thanks for taking care of this one! |
|
I have tested this item ✅ successfully on 182ceb1 @joomdonation I'd keep those global parameters, as there may be use cases for setting CSS classes globally, and I don't see any disadvantages. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428. |
@Harmageddon Did you do that directly from 3.9.26 to 4 and not with an intermediate 3.10? That might work when using "Upload & Update" but is not officially supported. It's ok for the test here, but I thought I should spread the information that it's not the official way. (Sorry I've first mentioned the wrong person here, so @himanshu007-creator please ignore the notification.) |
Ah yes, you're perfectly right there. I couldn't find my old backup I used for upgrade tests, that was probably on 3.10, and just picked a new download package. Sorry for that, still it worked! :-D |
|
Had already successfully used this procedure J 3.10 to J 4.0 a few times ... and at that time in the course of #31570 etc. Backup today of my J 3.10 imported again. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428. |
|
I have tested this item ✅ successfully on 182ceb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428. |
|
Thank you! |
Pull Request for Issue #33379
Summary of Changes
Remove migration script for blog layout as now the function is no longer needed.
Testing Instructions
Install J3.10 and make some blogs with entries in num_columns. Update to J4.0
in J4.0, blog must have same same columns as there were in J3.10
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none