[4.0] Empty State for Banner clients and tracks #33376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as abuse.
This comment was marked as abuse.
PhilETaylor
reviewed
Apr 27, 2021
| use Joomla\CMS\Factory; | ||
| use Joomla\CMS\Layout\LayoutHelper; | ||
|
|
||
| $displayData = array( |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
PhilETaylor
reviewed
Apr 27, 2021
| 'helpURL' => 'https://docs.joomla.org/Special:MyLanguage/Help40:Banners:_Clients', | ||
| 'icon' => 'icon-bookmark banners', | ||
| ); | ||
| $user = Factory::getUser(); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
PhilETaylor
reviewed
Apr 27, 2021
|
|
||
| use Joomla\CMS\Layout\LayoutHelper; | ||
|
|
||
| $displayData = array( |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
PhilETaylor
reviewed
Apr 27, 2021
| COM_BANNERS_CLIENT_EMPTYSTATE_BUTTON_ADD="Add your first client" | ||
| COM_BANNERS_CLIENT_EMPTYSTATE_CONTENT="A Banner Client contains contact details and further information such as tracking preferences." | ||
| COM_BANNERS_CLIENT_EMPTYSTATE_TITLE="No Clients have been created yet." | ||
| COM_BANNERS_CLIENT_EDIT="Edit Client" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as the other PRs
If you have never used the banner component - in order to test the tracks part of this PR and make sure its not displayed when there is tracking info you will need to create a banner AND set the tracking to yes on the second tab of the banner.
After