[4.0] Fix Update Joomla Using FTP

[joomdonation]

Pull Request for Issue # .

Summary of Changes

During update process (using FTP or Hybrid installation method), Joomla! needs to write FTP credentials into restoration.php file so that these data can be used by restore.php on restoration process.

Due to a bug in getting FTP credentials (trying to get directly from input but these fields are not available in the input at all), update Joomla using these two methods never works (or at least it never works in the recent version). Also, the code in restore.php file does not like the path with window style, so I added some code to change it to Linux path style

Tested on my local Joomla 4 using Filezilla server and it worked. Not sure how to give testing instructions because now it is hard to find testers for FTP stuffs.

Testing Instructions

[brianteeman]

Doesn't the same problem exist in Joomla 3? At least from your description of the reason it would appear so.

[joomdonation]

Yes, same happens with Joomla 3. I just made the PR here quickly to prove that updates Joomla never works properly (at least for recent release, maybe from the time we added Upload and Update option back, I don't remember the time)

So the point here is if update is not working and no-one reports it, can we assume that no-one is using it? We can try to spend time to fix FTP issues, but if no one is using it, it will be a waste of time

[brianteeman]

So the point here is if update is not working and no-one reports it, can we assume that no-one is using it? We can try to spend time to fix FTP issues, but if no one is using it, it will be a waste of time

That's what I've been trying to say but people keep sidetracking with conversations about code purity

[joomdonation]

Hope this PR shows something. If update Joomla not working, if install extensions not working (as I saw somewhere from list of issues which Phil mentioned) and no-one complains, we should not have to spend time to fix it.

[joomdonation]

Is this related to this Joomla 3 issue? #28199

Yes, I think so.

[richard67]

Drone resuscitated 😄 .

[joomdonation]

Closing because FTP layer will be dropped.

[richard67]

Closing because FTP layer will be dropped.

@joomdonation Who says that?

[joomdonation]

@richard67 See #33390 (comment)