Skip to content

[4.0] On updating Joomla, "Overridden files have changed" message should be linked to allow resolution. #33256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[4.0] On updating Joomla, "Overridden files have changed" message should be linked to allow resolution. #33256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec93ee8
first commit
brianteeman Apr 22, 2021
cb16ded
.
brianteeman Apr 22, 2021
20b18c1
move variables
brianteeman Apr 23, 2021
590f64a
enter
brianteeman Apr 23, 2021
320fa88
helper
brianteeman Apr 23, 2021
a02c949
Update plugins/installer/override/override.php
brianteeman Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions administrator/language/en-GB/plg_installer_override.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
; Note : All ini files need to be saved as UTF-8

PLG_INSTALLER_OVERRIDE="Installer - Override"
PLG_INSTALLER_OVERRIDE_COMPONENT_LINK="Check the overrides in the %s."
PLG_INSTALLER_OVERRIDE_N_FILE_UPDATED="%s Overridden files have changed."
PLG_INSTALLER_OVERRIDE_N_FILE_UPDATED_1="Overridden file has changed."
PLG_INSTALLER_OVERRIDE_PLUGIN_XML_DESCRIPTION="This plugin enables notifications and handling of overrides after an update in case of changes."
5 changes: 5 additions & 0 deletions plugins/installer/override/override.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@

use Joomla\CMS\Application\CMSApplicationInterface;
use Joomla\CMS\Date\Date;
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Plugin\CMSPlugin;
use Joomla\CMS\Uri\Uri;
use Joomla\Database\ParameterType;

/**
Expand Down Expand Up @@ -192,7 +194,10 @@ public function finalize($result)

if ($num != 0)
{
$url = Uri::base() . 'index.php?option=com_templates&view=templates';
$link = HTMLHelper::_('link', $url, Text::_('COM_TEMPLATES'), 'class="alert-link"');
$this->app->enqueueMessage(Text::plural('PLG_INSTALLER_OVERRIDE_N_FILE_UPDATED', $num), 'notice');
$this->app->enqueueMessage(Text::sprintf('PLG_INSTALLER_OVERRIDE_COMPONENT_LINK', $link), 'notice');
$this->saveOverrides($result);
}

Expand Down