Skip to content

[4.0] Apostrophe in alias #32924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdeutz merged 4 commits into from
Mar 30, 2021
Merged

[4.0] Apostrophe in alias #32924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46587f9
[4.0] Apostrophe in alias
brianteeman Mar 29, 2021
07ee756
first try at writing a test
brianteeman Mar 29, 2021
0e0b01d
second
brianteeman Mar 29, 2021
d83aacd
Update OutputFilter.php
brianteeman Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libraries/src/Filter/OutputFilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ public static function stringURLSafe($string, $language = '')
// Trim white spaces at beginning and end of alias and make lowercase
$str = trim(StringHelper::strtolower($str));

// Remove any apostrophe. We do it here to ensure it is not replaced by a '-'
$str = str_replace("'", '', $str);

// Remove any duplicate whitespace, and ensure all characters are alphanumeric
$str = preg_replace('/(\s|[^A-Za-z0-9\-])+/', '-', $str);

Expand Down
6 changes: 6 additions & 0 deletions tests/Unit/Libraries/Cms/Filter/OutputFilterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ public function testStringURLSafe()
OutputFilter::stringURLSafe('`1234567890-=~!@#$%^&*()_+ qwertyuiop[]\QWERTYUIOP{}|asdfghjkl;\'ASDFGHJKL:"zxcvbnm,./ZXCVBNM<>?'),
'Should clean keyboard string down to ASCII-7'
);

$this->assertEquals(
'joomlas-version',
OutputFilter::stringURLSafe('joomla\'s version'),
'Should remove apostrophe from the string'
);
}

/**
Expand Down